Merge lp:~mterry/unity8/new-backgrounds into lp:unity8

Proposed by Michael Terry
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 787
Merged at revision: 849
Proposed branch: lp:~mterry/unity8/new-backgrounds
Merge into: lp:unity8
Diff against target: 4 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp:~mterry/unity8/new-backgrounds
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Jouni Helminen Pending
Review via email: mp+212723@code.launchpad.net

Commit message

Use new tablet and phone backgrounds from Design.

Description of the change

Use new tablet and phone backgrounds from Design.

I also removed a darkening rectangle. I'm not sure why it was there? Jouni from Design noticed things were darker than he'd like.

== Checklist ==

 * Are there any related MPs required for this MP to build/function as expected? Please list.
 - No, but a very related branch is https://code.launchpad.net/~mterry/unity8/greeter-ux-fixes/+merge/210042

 * Did you perform an exploratory manual test run of your code change and any related functionality?
 - Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
 - N/A

 * If you changed the UI, has there been a design review?
 - Yes, these files are from design.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:785
http://jenkins.qa.ubuntu.com/job/unity8-ci/2634/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4253
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3837/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1504
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1155
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1159
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1159/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1155
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3688
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4329
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4329/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3839
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3839/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/6125/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/5205

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2634/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

The rectangle was added here, probably a design request: http://bazaar.launchpad.net/~unity-team/unity/phablet/revision/110.1.1

Can be removed if we're happy without it.

However, wallpapers resolutions are low, 480x853 and 1200x800.

review: Needs Fixing
Revision history for this message
Jouni Helminen (jounihelminen) wrote :

The dark rectangle was there probably to add some contrast separation between the wallpaper and the infographic.

Michael would you be able to post a screenshot of how the greeter looks with the new wallpaper and no dark rectangle?

The wallpaper resolutions match what we have today - we can update them to full HD for the phone and 2560x1600 for tablet but last time we tried that, people were complaining about memory consumption

Revision history for this message
Michael Terry (mterry) wrote :
Revision history for this message
Michael Terry (mterry) wrote :

Jouni, I think I sent an email the other day, but in case not, here's another poke. We want to try the full HD wallpapers (since the previous memory consumption issues were specific to a device we no longer support).

Revision history for this message
Andrea Cimitan (cimi) wrote :

Yes please!

 * Did you perform an exploratory manual test run of the code change and any related functionality?
yes

 * Did CI run pass? If not, please explain why.
grumpy jenkins (unrelated)

review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

Cimi, I know you already approved, but in testing I realized that removing the darkening of the background makes it harder to see the infographic bubbles. Which I'm guessing is the real reason for the darkening.

So I added it back, making this branch *just* image asset changes.

Until we can get Jouni comments on infographic bubbles & darkening, let's just make the safest changes possible. We can address the darkening in a different branch.

Revision history for this message
Andrea Cimitan (cimi) wrote :

Well, fine both ways

 * Did you perform an exploratory manual test run of the code change and any related functionality?
yes

 * Did CI run pass? If not, please explain why.
grumpy jenkins (unrelated)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/graphics/phone_background.jpg'
2Binary files qml/graphics/phone_background.jpg 2013-06-05 22:03:08 +0000 and qml/graphics/phone_background.jpg 2014-04-14 16:29:42 +0000 differ
3=== modified file 'qml/graphics/tablet_background.jpg'
4Binary files qml/graphics/tablet_background.jpg 2013-06-05 22:03:08 +0000 and qml/graphics/tablet_background.jpg 2014-04-14 16:29:42 +0000 differ

Subscribers

People subscribed via source and target branches