Merge lp:~mterry/unity8/narrow-mouse-hack into lp:unity8
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Lukáš Tinkl | ||||
Approved revision: | 2175 | ||||
Merged at revision: | 2250 | ||||
Proposed branch: | lp:~mterry/unity8/narrow-mouse-hack | ||||
Merge into: | lp:unity8 | ||||
Diff against target: |
94 lines (+26/-4) 4 files modified
qml/Greeter/CoverPage.qml (+13/-2) qml/Greeter/Infographics.qml (+2/-1) qml/Greeter/NarrowView.qml (+2/-1) tests/qmltests/Greeter/tst_NarrowView.qml (+9/-0) |
||||
To merge this branch: | bzr merge lp:~mterry/unity8/narrow-mouse-hack | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lukáš Tinkl (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Unity8 CI Bot | continuous-integration | Approve | |
Review via email: mp+284804@code.launchpad.net |
Commit message
To let the user log in if a mouse is connected, hide the greeter cover page on a mouse click (but NOT a touch click).
Description of the change
This is just a short-term hack until design gives us a more mouse-friendly option for the greeter.
(While testing, I noticed that it was odd that the infographic didn't do anything when clicked if there was no data -- to the user, there is no feedback. So I turned off its double-click detector if there is no text.)
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
NA
* If you changed the UI, has there been a design review?
NA
FAILED: Continuous integration, rev:2173 /unity8- jenkins. ubuntu. com/job/ lp-unity8- 1-ci/258/
https:/
Executed test runs:
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- 1-ci/258/ rebuild
https:/