Merge lp:~mterry/unity8/greeter-osk into lp:unity8
Proposed by
Michael Terry
on 2017-03-07
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michał Sawicz on 2017-03-08 | ||||
| Approved revision: | 2841 | ||||
| Merged at revision: | 2841 | ||||
| Proposed branch: | lp:~mterry/unity8/greeter-osk | ||||
| Merge into: | lp:unity8 | ||||
| Diff against target: |
28 lines (+7/-4) 1 file modified
data/unity8-greeter-wrapper (+7/-4) |
||||
| To merge this branch: | bzr merge lp:~mterry/unity8/greeter-osk | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michał Sawicz | 2017-03-07 | Approve on 2017-03-08 | |
| Unity8 CI Bot | continuous-integration | Approve on 2017-03-07 | |
|
Review via email:
|
|||
Commit Message
Set QT_IM_MODULE in the greeter so that the OSK can come up.
Description of the Change
And do a little bit of cleanup.
When testing, make sure that stay-hidden is false. It might have been true from past versions of unity8.
sudo -H -u lightdm dbus-run-session gsettings get com.canonical.
You'll also note that once you enable the OSK, you can't turn it off again.
To post a comment you must log in.
| Michał Sawicz (saviq) wrote : | # |
* Did you perform an exploratory manual test run of the code change and any related functionality?
Y
* Did CI run pass? If not, please explain why.
Y
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:2841
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/