Merge lp:~mterry/unity8/gnome-session-quit into lp:unity8
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | 2870 |
Merged at revision: | 2869 |
Proposed branch: | lp:~mterry/unity8/gnome-session-quit |
Merge into: | lp:unity8 |
Diff against target: |
291 lines (+186/-8) 6 files modified
plugins/Unity/Session/dbusunitysessionservice.cpp (+46/-1) plugins/Unity/Session/dbusunitysessionservice.h (+18/-4) tests/plugins/Unity/Session/LogindServer.cpp (+10/-0) tests/plugins/Unity/Session/LogindServer.h (+5/-0) tests/plugins/Unity/Session/interfaces.xml (+12/-0) tests/plugins/Unity/Session/sessionbackendtest.cpp (+95/-3) |
To merge this branch: | bzr merge lp:~mterry/unity8/gnome-session-quit |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Approve | ||
Unity8 CI Bot | continuous-integration | Approve | |
Review via email: mp+319992@code.launchpad.net |
Commit message
Support GNOME-style logout DBus API (making the Logout, Reboot, and Shutdown launcher commands work)
Description of the change
As noted in bug 1673229, the launcher items "Logout", "Shutdown", and "Reboot" don't do anything in unity8. They are holdovers from GNOME, making calls to the org.gnome.
Despite being old-world commands, it would still be nice if we supported them (and other bits of code in classic Ubuntu might try similar calls to the API). Unity7 supports them. And we support the similar (older?) org.gnome.
You can test by logging into deb-based unity8 and running those commands from the launcher. There's still a momentary, jarring splash window created for the command. But that's a separate issue.
FAILED: Continuous integration, rev:2869 /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/3403/ /unity8- jenkins. ubuntu. com/job/ build/4484/ console /unity8- jenkins. ubuntu. com/job/ build-0- fetch/4512 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 4339/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= zesty/4339/ console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 4339/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= zesty/4339/ console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 4339/console /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= zesty/4339/ console
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/3403/ rebuild
https:/