Merge lp:~mterry/unity8/fix-greeter-retry into lp:unity8

[Michael Terry]

Fix showing "Retry" in password prompt when turning on screen in tablet mode.

When told to show the greeter (power button press or dbus request), we forcibly reset greeter state. This lets us catch when passwords change or the like by resetting the PAM stack.

In one case, we weren't resetting state hard enough and the password prompt thought it hadn't been prompted yet by PAM but still wasn't authorized. So it showed a "Retry" button instead of the normal password prompt.

This fixes that by going through the proper channels for a reset.

= To reproduce =

- Use tablet mode
- Log in
- Lock screen
- Turn screen on
- Turn screen off
- Turn screen on

You should now see a "Retry" button in the greeter password field.

= Checklist =

 * Are there any related MPs required for this MP to build/function as expected? Please list.
 No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
 Yes

 * Did you make sure that your branch does not contain spurious tags?
 yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
 NA

 * If you changed the UI, has there been a design review?
 NA

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2297
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/761/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1000
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1016
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1016
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1014/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1014/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1014/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1014/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1014/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1014/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/761/rebuild

review: Needs Fixing (continuous-integration)

[lp:~mterry/unity8/fix-greeter-retry]

2279. By Michael Terry on 2016-03-17

Reset greeter state a little harder, to avoid half-done state

2280. By Michael Terry on 2016-03-22

Fix tests and add check for new behavior

Unmerged revisions

=== modified file 'qml/Greeter/Greeter.qml'
--- qml/Greeter/Greeter.qml	2016-01-11 17:37:02 +0000
+++ qml/Greeter/Greeter.qml	2016-03-17 00:58:13 +0000
@@ -60,7 +60,7 @@
 
     function forceShow() {
         showNow();
-        loader.item.reset();
+        d.selectUser(d.currentIndex, true);
     }
 
     function notifyAppFocused(appId) {