Merge lp:~mterry/unity8/expose-lockscreen-passphrase into lp:unity8

[Michael Terry]

Expose a 'passphrase' field of Components.Lockscreen to allow consumers (like the wizard) to query the password content before the user finishes. Needed to provide a proper Continue button in the welcome wizard.

I know that passphrase isn't the *best* field name, considering it works for a passcode too. But we already expose that phrase for both in the accepted() signal. So for consistency, I kept it the same.

And I bumped the unity8 version, so that ubuntu-system-settings can depend on this new field.

Expose a 'passphrase' field of Components.Lockscreen to allow consumers (like the wizard) to query the password content before the user finishes. Needed to provide a proper Continue button in the welcome wizard.

I know that passphrase isn't the *best* field name, considering it works for a passcode too. But we already expose that phrase for both in the accepted() signal. So for consistency, I kept it the same.

And I bumped the unity8 version, so that ubuntu-system-settings can depend on this new field.

== Checklist ==

 * Are there any related MPs required for this MP to build/function as expected? Please list.
 No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
 Yes

 * Did you make sure that your branch does not contain spurious tags?
 Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
 I am in that team

 * If you changed the UI, has there been a design review?
 NA

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1370
http://jenkins.qa.ubuntu.com/job/unity8-ci/4751/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6171/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1737
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1847
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1845
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5794/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7423
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7423/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15006

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4751/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
No functional change.
 * Did CI run pass? If not, please explain why.
Not AP :/
 * Did you make sure that the branch does not contain spurious tags?
Y

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2014-10-13 15:43:04 +0000
+++ debian/changelog	2014-10-23 13:26:46 +0000
@@ -1,3 +1,9 @@
+unity8 (8.01) UNRELEASED; urgency=medium
+
+  * Provide 'passphrase' as a field of Components.Lockscreen
+
+ -- Michael Terry <[e-mail]>  Wed, 22 Oct 2014 16:05:26 -0400
+
 unity8 (8.00+14.10.20141013.2-0ubuntu1) utopic; urgency=low
 
   [ Michael Terry ]

=== modified file 'qml/Components/Lockscreen.qml'
--- qml/Components/Lockscreen.qml	2014-10-07 08:19:36 +0000
+++ qml/Components/Lockscreen.qml	2014-10-23 13:26:46 +0000
@@ -56,6 +56,8 @@
 
     property url background: ""
 
+    readonly property string passphrase: (pinPadLoader.item && pinPadLoader.item.passphrase) ? pinPadLoader.item.passphrase : ""
+
     signal entered(string passphrase)
     signal cancel()
     signal emergencyCall()

=== modified file 'qml/Components/PassphraseLockscreen.qml'
--- qml/Components/PassphraseLockscreen.qml	2014-09-25 13:53:52 +0000
+++ qml/Components/PassphraseLockscreen.qml	2014-10-23 13:26:46 +0000
@@ -28,6 +28,8 @@
     property string errorText
     property bool entryEnabled: true
 
+    readonly property string passphrase: pinentryField.text
+
     signal entered(string passphrase)
     signal cancel()
 

=== modified file 'qml/Components/PinLockscreen.qml'
--- qml/Components/PinLockscreen.qml	2014-10-08 14:31:53 +0000
+++ qml/Components/PinLockscreen.qml	2014-10-23 13:26:46 +0000
@@ -35,6 +35,8 @@
     property int maxPinLength: -1
     property bool showCancelButton: true
 
+    readonly property string passphrase: pinentryField.text
+
     signal entered(string passphrase)
     signal cancel()