Merge lp:~mterry/unity/phablet-narrowMode into lp:unity/phablet

Proposed by Michael Terry
Status: Superseded
Proposed branch: lp:~mterry/unity/phablet-narrowMode
Merge into: lp:unity/phablet
Diff against target: 14 lines (+3/-1)
1 file modified
Greeter/GreeterContent.qml (+3/-1)
To merge this branch: bzr merge lp:~mterry/unity/phablet-narrowMode
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+167552@code.launchpad.net

This proposal has been superseded by a proposal from 2013-06-06.

Commit message

Show login list when not in narrow mode, instead of only when we have multiple users.

Description of the change

Show login list when not in narrow mode, instead of only when we have multiple users. This basically means that if the screen becomes big enough, we'll show login list.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

As we all agree this is a intermediate solution it might classify for a //TODO or //FIXME to keep it in the radar whenever grepping for such stuff.

Revision history for this message
Michael Terry (mterry) wrote :

Updated with a comment.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Greeter/GreeterContent.qml'
2--- Greeter/GreeterContent.qml 2013-06-03 15:32:21 +0000
3+++ Greeter/GreeterContent.qml 2013-06-05 19:10:32 +0000
4@@ -73,7 +73,9 @@
5 width: units.gu(29)
6 height: parent.height
7
8- source: greeter.multiUser ? "LoginList.qml" : ""
9+ // TODO: Once we have a system API for determining which mode we are
10+ // in, tablet/phone/desktop, that should be used instead of narrowMode.
11+ source: greeter.narrowMode ? "" : "LoginList.qml"
12
13 onLoaded: {
14 item.currentIndex = greeterContentLoader.currentIndex

Subscribers

People subscribed via source and target branches