Merge lp:~mterry/unity/fix-crash-727788 into lp:unity

[Michael Terry]

[Rodrigo Moya (rodrigo-moya)]

This fix is wrong, the problem is the call to atk_object_notify_state_change, which shouldn't be there. It's already fixed in this other branch: https://code.launchpad.net/~rodrigo-moya/unity/sync-geometries/+merge/51929 which removes that call

review: Disapprove

[Didier Roche-Tolomelli (didrocks)]

Syncing the state to rejected to clean the list

Unmerged revisions

918. By Michael Terry on 2011-03-02

make PanelIndicatorEntryAccessible's finalize into dispose to fix crashes

=== modified file 'services/panel-indicator-entry-accessible.c'
--- services/panel-indicator-entry-accessible.c	2011-02-28 15:51:27 +0000
+++ services/panel-indicator-entry-accessible.c	2011-03-02 13:58:19 +0000
@@ -66,7 +66,7 @@
 }
 
 static void
-panel_indicator_entry_accessible_finalize (GObject *object)
+panel_indicator_entry_accessible_dispose (GObject *object)
 {
   PanelIndicatorEntryAccessible *piea;
 
@@ -81,7 +81,7 @@
       g_signal_handlers_disconnect_by_func (piea->priv->service, on_entry_activated_cb, piea);
     }
 
-  G_OBJECT_CLASS (panel_indicator_entry_accessible_parent_class)->finalize (object);
+  G_OBJECT_CLASS (panel_indicator_entry_accessible_parent_class)->dispose (object);
 }
 
 static void
@@ -92,7 +92,7 @@
 
   /* GObject */
   object_class = G_OBJECT_CLASS (klass);
-  object_class->finalize = panel_indicator_entry_accessible_finalize;
+  object_class->dispose = panel_indicator_entry_accessible_dispose;
 
   /* AtkObject */
   atk_class = ATK_OBJECT_CLASS (klass);