Merge lp:~mterry/unity/851954 into lp:unity
Status: | Merged |
---|---|
Approved by: | Michal Hruby |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1749 |
Proposed branch: | lp:~mterry/unity/851954 |
Merge into: | lp:unity |
Diff against target: |
26 lines (+8/-1) 1 file modified
services/panel-service.c (+8/-1) |
To merge this branch: | bzr merge lp:~mterry/unity/851954 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Approve | ||
Review via email: mp+81916@code.launchpad.net |
Description of the change
In https:/
But destroying the widget causes dispose to be run, and GtkMenuShell's dispose causes "deactivate" to run.
I'm pretty sure I tested this code and didn't get this behavior. So either this sequence changed or I'm misremembering. Regardless, it's like that now.
One fix is simply to disconnect the signal handler when we get that signal, done in this branch.
I'm not sure how to reproduce though. The related bug does not give useful information to get to this state. And the steps from my original merge don't work anymore, since indicator-appmenu is better these days. :-/
But the branch seems obviously correct to me.
Looks good to me, this should fix the issue.