Merge lp:~mterry/unity-system-compositor/mir-fixes into lp:unity-system-compositor

Proposed by Michael Terry
Status: Merged
Merged at revision: 91
Proposed branch: lp:~mterry/unity-system-compositor/mir-fixes
Merge into: lp:unity-system-compositor
Diff against target: 55 lines (+10/-6)
2 files modified
debian/control (+1/-1)
src/system_compositor.cpp (+9/-5)
To merge this branch: bzr merge lp:~mterry/unity-system-compositor/mir-fixes
Reviewer Review Type Date Requested Status
Timo Jyrinki (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Daniel van Vugt Approve
Robert Ancell Approve
Review via email: mp+192042@code.launchpad.net

Commit message

Mir trunk changed some symbols on us, so we shall follow suit.

Description of the change

Mir trunk changed some symbols on us, so here we are to keep pace.

I assume we don't want to make particular use of the new started() method, so I just left our override blank.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Makes sense to me as long as that version of Mir is available.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Oh, of course. CI will fail until the Mir 0.1.0 packages are released :/

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Tested with the daily-build PPA that merging this will fix building against libmirserver8. Merging manually.

review: Approve
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

...the only problem being that meanwhile there's libmirserver9 which new problems for u-s-c. Let's see.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-10-14 19:39:39 +0000
3+++ debian/control 2013-10-21 19:36:26 +0000
4@@ -6,7 +6,7 @@
5 cmake-data,
6 debhelper (>= 9),
7 libboost1.48-all-dev | libboost-all-dev,
8- libmirserver-dev (>= 0.0.15),
9+ libmirserver-dev (>= 0.0.16),
10 libgles2-mesa-dev,
11 libprotobuf-dev,
12 pkg-config,
13
14=== modified file 'src/system_compositor.cpp'
15--- src/system_compositor.cpp 2013-09-30 16:52:36 +0000
16+++ src/system_compositor.cpp 2013-10-21 19:36:26 +0000
17@@ -20,7 +20,7 @@
18
19 #include <mir/run_mir.h>
20 #include <mir/abnormal_exit.h>
21-#include <mir/pause_resume_listener.h>
22+#include <mir/server_status_listener.h>
23 #include <mir/shell/application_session.h>
24 #include <mir/shell/session.h>
25 #include <mir/shell/session_container.h>
26@@ -98,11 +98,11 @@
27 return std::make_shared<NullCursorListener>();
28 }
29
30- std::shared_ptr<mir::PauseResumeListener> the_pause_resume_listener() override
31+ std::shared_ptr<mir::ServerStatusListener> the_server_status_listener() override
32 {
33- struct PauseResumeListener : public mir::PauseResumeListener
34+ struct ServerStatusListener : public mir::ServerStatusListener
35 {
36- PauseResumeListener (SystemCompositor *compositor) : compositor{compositor} {}
37+ ServerStatusListener (SystemCompositor *compositor) : compositor{compositor} {}
38
39 void paused() override
40 {
41@@ -114,9 +114,13 @@
42 compositor->resume();
43 }
44
45+ void started() override
46+ {
47+ }
48+
49 SystemCompositor *compositor;
50 };
51- return std::make_shared<PauseResumeListener>(compositor);
52+ return std::make_shared<ServerStatusListener>(compositor);
53 }
54
55 std::string get_socket_file()

Subscribers

People subscribed via source and target branches