Merge lp:~mterry/unity-lens-files/modern-build into lp:unity-lens-files

Proposed by Michael Terry
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 243
Merged at revision: 243
Proposed branch: lp:~mterry/unity-lens-files/modern-build
Merge into: lp:unity-lens-files
Diff against target: 101 lines (+21/-15)
7 files modified
data/Makefile.am (+1/-1)
data/unity-lens-files.service.in (+1/-1)
debian/changelog (+4/-0)
debian/compat (+1/-1)
debian/control (+1/-2)
debian/rules (+12/-9)
src/Makefile.am (+1/-1)
To merge this branch: bzr merge lp:~mterry/unity-lens-files/modern-build
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+133586@code.launchpad.net

Commit message

Use dh9 instead of cdbs, use --fail-missing, and install daemon into pkglibexecdir.

Description of the change

Modernize build system a bit:
 * Switch from cdbs to dh9 (which enables tests during build)
 * Use --fail-missing
 * Install daemon into pkglibexecdir instead of libexecdir

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

changes look good, pbuilder doesn't complain, and the "no test" runs well ;)
Approving.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/Makefile.am'
2--- data/Makefile.am 2012-03-02 09:45:17 +0000
3+++ data/Makefile.am 2012-11-08 22:52:20 +0000
4@@ -3,7 +3,7 @@
5 dbus_services_DATA = $(service_in_files:.service.in=.service)
6
7 %.service: %.service.in
8- sed -e "s|\@libexecdir\@|$(libexecdir)|" $< > $@
9+ sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
10
11 #############################################################
12 # GSettings schemas
13
14=== modified file 'data/unity-lens-files.service.in'
15--- data/unity-lens-files.service.in 2011-08-11 14:06:59 +0000
16+++ data/unity-lens-files.service.in 2012-11-08 22:52:20 +0000
17@@ -1,3 +1,3 @@
18 [D-BUS Service]
19 Name=com.canonical.Unity.Lens.Files
20-Exec=@libexecdir@/unity-files-daemon
21+Exec=@pkglibexecdir@/unity-files-daemon
22
23=== modified file 'debian/changelog'
24--- debian/changelog 2012-11-06 15:39:07 +0000
25+++ debian/changelog 2012-11-08 22:52:20 +0000
26@@ -1,10 +1,14 @@
27 unity-lens-files (6.6.0-0ubuntu2) UNRELEASED; urgency=low
28
29+ * Install daemon into pkglibexecdir, not libexecdir
30 * debian/control:
31 - Update Vcs-Bzr
32 - Build-Depend on gnome-common
33+ - Bump required version of debhelper, drop cdbs
34 * debian/rules:
35 - Have dh_autoreconf call ./autogen.sh
36+ - Switch from cdbs to dh9, running tests in the bargain
37+ - Use --fail-missing
38
39 -- Michael Terry <mterry@ubuntu.com> Tue, 06 Nov 2012 10:38:14 -0500
40
41
42=== modified file 'debian/compat'
43--- debian/compat 2010-06-18 14:45:04 +0000
44+++ debian/compat 2012-11-08 22:52:20 +0000
45@@ -1,1 +1,1 @@
46-7
47+9
48
49=== modified file 'debian/control'
50--- debian/control 2012-11-06 15:39:07 +0000
51+++ debian/control 2012-11-08 22:52:20 +0000
52@@ -2,8 +2,7 @@
53 Section: gnome
54 Priority: optional
55 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
56-Build-Depends: cdbs,
57- debhelper (>= 7),
58+Build-Depends: debhelper (>= 9),
59 gnome-common,
60 pkg-config,
61 valac (>= 0.16),
62
63=== modified file 'debian/rules'
64--- debian/rules 2012-11-06 15:39:07 +0000
65+++ debian/rules 2012-11-08 22:52:20 +0000
66@@ -1,10 +1,13 @@
67 #!/usr/bin/make -f
68-
69-include /usr/share/cdbs/1/class/gnome.mk
70-include /usr/share/cdbs/1/rules/debhelper.mk
71-include /usr/share/cdbs/1/rules/utils.mk
72-include /usr/share/cdbs/1/rules/autoreconf.mk
73-
74-LDFLAGS += -Wl,-z,defs -Wl,--as-needed
75-DEB_DH_AUTORECONF_ARGS = env -- NOCONFIGURE=1 ./autogen.sh
76-
77+# -*- Mode: Makefile; indent-tabs-mode: t -*-
78+
79+export DEB_LDFLAGS_MAINT_APPEND = -Wl,-z,defs -Wl,--as-needed
80+
81+%:
82+ dh $@ --with autoreconf
83+
84+override_dh_autoreconf:
85+ NOCONFIGURE=1 dh_autoreconf ./autogen.sh
86+
87+override_dh_install:
88+ dh_install --fail-missing
89
90=== modified file 'src/Makefile.am'
91--- src/Makefile.am 2012-03-23 14:06:10 +0000
92+++ src/Makefile.am 2012-11-08 22:52:20 +0000
93@@ -5,7 +5,7 @@
94
95 DATADIR = $(datadir)
96
97-libexec_PROGRAMS = \
98+pkglibexec_PROGRAMS = \
99 unity-files-daemon
100
101 unity_files_daemon_CPPFLAGS = \

Subscribers

People subscribed via source and target branches