Merge lp:~mterry/unity-lens-applications/modern-build into lp:unity-lens-applications

Proposed by Michael Terry
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 318
Merged at revision: 318
Proposed branch: lp:~mterry/unity-lens-applications/modern-build
Merge into: lp:unity-lens-applications
Prerequisite: lp:~mterry/unity-lens-applications/sync-packaging
Diff against target: 104 lines (+19/-17)
8 files modified
data/Makefile.am (+1/-1)
data/unity-lens-applications.service.in (+1/-1)
debian/changelog (+4/-0)
debian/compat (+1/-1)
debian/control (+1/-2)
debian/rules (+10/-9)
debian/unity-lens-applications.install (+0/-2)
src/Makefile.am (+1/-1)
To merge this branch: bzr merge lp:~mterry/unity-lens-applications/modern-build
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+133402@code.launchpad.net

Commit message

Switch from cdbs to dh9 and run tests

Description of the change

Use a more modern build system for debian/:
 * Switch from cdbs to dh9
 * Use --fail-missing (not strictly needed, since we only have one binary package, but helps for future-proofing)
 * Automatically run tests due to dh9
 * Change from libexecdir to pkglibexecdir, now that dh9 fixes the long standing bug that set the wrong libexecdir

Note that debian/unity-lens-applications.install is dropped because dh9 automatically installs everything that the upstream build system does for you, as long as there is only one binary package. So the .install file is superfluous (and actually harmful as it causes a build problem).

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Works completely fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/Makefile.am'
2--- data/Makefile.am 2011-11-15 12:31:25 +0000
3+++ data/Makefile.am 2012-11-08 04:51:21 +0000
4@@ -6,7 +6,7 @@
5 dbus_services_DATA = $(service_in_files:.service.in=.service)
6
7 %.service: %.service.in
8- sed -e "s|\@libexecdir\@|$(libexecdir)|" $< > $@
9+ sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
10
11 #############################################################
12 # XDG Menu files
13
14=== modified file 'data/unity-lens-applications.service.in'
15--- data/unity-lens-applications.service.in 2011-08-04 07:04:35 +0000
16+++ data/unity-lens-applications.service.in 2012-11-08 04:51:21 +0000
17@@ -1,3 +1,3 @@
18 [D-BUS Service]
19 Name=com.canonical.Unity.Lens.Applications
20-Exec=@libexecdir@/unity-applications-daemon
21+Exec=@pkglibexecdir@/unity-applications-daemon
22
23=== modified file 'debian/changelog'
24--- debian/changelog 2012-11-08 04:51:21 +0000
25+++ debian/changelog 2012-11-08 04:51:21 +0000
26@@ -3,7 +3,11 @@
27 * debian/control:
28 - Update Vcs-Bzr
29 - Bump required valac to 0.18
30+ - Bump required debhelper to 9 and drop cdbs
31 - Fix libgnome-menu-dev Build-Dep to be libgnome-menu-3-dev
32+ * debian/rules:
33+ - Use dh9 instead of cdbs
34+ - Use --fail-missing
35
36 -- Michael Terry <mterry@ubuntu.com> Wed, 07 Nov 2012 23:10:52 -0500
37
38
39=== modified file 'debian/compat'
40--- debian/compat 2010-06-23 09:51:59 +0000
41+++ debian/compat 2012-11-08 04:51:21 +0000
42@@ -1,1 +1,1 @@
43-7
44+9
45
46=== modified file 'debian/control'
47--- debian/control 2012-11-08 04:51:21 +0000
48+++ debian/control 2012-11-08 04:51:21 +0000
49@@ -2,8 +2,7 @@
50 Section: gnome
51 Priority: optional
52 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
53-Build-Depends: cdbs,
54- debhelper (>= 7),
55+Build-Depends: debhelper (>= 9),
56 gnome-common,
57 pkg-config,
58 valac-0.18 (>= 0.18.0),
59
60=== modified file 'debian/rules'
61--- debian/rules 2012-11-05 19:18:41 +0000
62+++ debian/rules 2012-11-08 04:51:21 +0000
63@@ -1,11 +1,12 @@
64 #!/usr/bin/make -f
65
66-include /usr/share/cdbs/1/class/gnome.mk
67-include /usr/share/cdbs/1/rules/debhelper.mk
68-include /usr/share/cdbs/1/rules/utils.mk
69-include /usr/share/cdbs/1/rules/autoreconf.mk
70-
71-LDFLAGS += -Wl,-z,defs -Wl,--as-needed
72-DEB_DH_AUTORECONF_ARGS = env -- NOCONFIGURE=1 ./autogen.sh
73-DEB_CONFIGURE_EXTRA_FLAGS += --sysconfdir=/etc
74-
75+export DEB_LDFLAGS_MAINT_APPEND = -Wl,-z,defs -Wl,--as-needed
76+
77+%:
78+ dh $@ --with autoreconf
79+
80+override_dh_autoreconf:
81+ NOCONFIGURE=1 dh_autoreconf ./autogen.sh
82+
83+override_dh_install:
84+ dh_install --fail-missing
85
86=== removed file 'debian/unity-lens-applications.install'
87--- debian/unity-lens-applications.install 2011-08-04 08:30:33 +0000
88+++ debian/unity-lens-applications.install 1970-01-01 00:00:00 +0000
89@@ -1,2 +0,0 @@
90-etc/
91-usr/
92
93=== modified file 'src/Makefile.am'
94--- src/Makefile.am 2012-11-05 19:18:41 +0000
95+++ src/Makefile.am 2012-11-08 04:51:21 +0000
96@@ -5,7 +5,7 @@
97
98 DATADIR = $(datadir)
99
100-libexec_PROGRAMS = \
101+pkglibexec_PROGRAMS = \
102 unity-applications-daemon
103
104 unity_applications_daemon_CPPFLAGS = \

Subscribers

People subscribed via source and target branches