Merge lp:~mterry/unity-greeter/screen-reader into lp:unity-greeter

Proposed by Michael Terry on 2012-01-09
Status: Merged
Merged at revision: 243
Proposed branch: lp:~mterry/unity-greeter/screen-reader
Merge into: lp:unity-greeter
Diff against target: 40 lines (+19/-4)
1 file modified
src/user-list.vala (+19/-4)
To merge this branch: bzr merge lp:~mterry/unity-greeter/screen-reader
Reviewer Review Type Date Requested Status
Unity Greeter Development Team 2012-01-09 Pending
Review via email: mp+87911@code.launchpad.net

Description of the change

Launch orca when users asks for it (without any windows popping up)

To post a comment you must log in.
Robert Ancell (robert-ancell) wrote :

Committed with brace and comment style fixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/user-list.vala'
2--- src/user-list.vala 2011-12-09 18:06:18 +0000
3+++ src/user-list.vala 2012-01-09 10:14:23 +0000
4@@ -569,6 +569,12 @@
5
6 private void keyboard_toggled_cb (Gtk.CheckMenuItem item)
7 {
8+ // FIXME: The below would be sufficient if gnome-session were running
9+ // to notice and run a screen keyboard in /etc/xdg/autostart... But
10+ // since we're not running gnome-session, we hardcode onboard here.
11+ //var settings = new Settings ("org.gnome.desktop.a11y.applications");
12+ //settings.set_boolean ("screen-keyboard-enabled", item.active);
13+
14 if (keyboard_window == null)
15 {
16 int id;
17@@ -646,10 +652,19 @@
18
19 private void screen_reader_toggled_cb (Gtk.CheckMenuItem item)
20 {
21- var settings = new Settings ("org.gnome.desktop.a11y.applications");
22- settings.set_boolean ("screen-reader-enabled", item.active);
23- settings = new Settings ("org.gnome.desktop.interface");
24- settings.set_boolean ("toolkit-accessibility", item.active);
25+ // FIXME: The below would be sufficient if gnome-session were running
26+ // to notice and run a screen reader in /etc/xdg/autostart... But
27+ // since we're not running gnome-session, we hardcode orca here.
28+ //var settings = new Settings ("org.gnome.desktop.a11y.applications");
29+ //settings.set_boolean ("screen-reader-enabled", item.active);
30+
31+ // Hardcoded orca:
32+ if (item.active) {
33+ Process.spawn_command_line_async ("orca --replace --no-setup --disable=splash-window --disable=main-window");
34+ }
35+ else {
36+ Process.spawn_command_line_async ("orca --quit");
37+ }
38 }
39
40 public void show_message (string text, bool error = false)

Subscribers

People subscribed via source and target branches