Merge lp:~mterry/unity-greeter/remote-login-hint into lp:unity-greeter

Proposed by Michael Terry
Status: Merged
Approved by: Robert Ancell
Approved revision: 573
Merged at revision: 602
Proposed branch: lp:~mterry/unity-greeter/remote-login-hint
Merge into: lp:unity-greeter
Diff against target: 71 lines (+12/-6)
5 files modified
data/com.canonical.unity-greeter.gschema.xml (+0/-4)
src/settings.vala (+0/-1)
src/unity-greeter.vala (+5/-0)
src/user-list.vala (+2/-1)
tests/unity-greeter.vala (+5/-0)
To merge this branch: bzr merge lp:~mterry/unity-greeter/remote-login-hint
Reviewer Review Type Date Requested Status
Unity Greeter Development Team Pending
Review via email: mp+123799@code.launchpad.net

Description of the change

To post a comment you must log in.
573. By Michael Terry

merge from trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/com.canonical.unity-greeter.gschema.xml'
2--- data/com.canonical.unity-greeter.gschema.xml 2012-08-21 14:49:00 +0000
3+++ data/com.canonical.unity-greeter.gschema.xml 2012-09-17 18:00:47 +0000
4@@ -82,9 +82,5 @@
5 <default>true</default>
6 <summary>Whether to play sound when greeter is ready</summary>
7 </key>
8- <key name="enable-remote-login" type="b">
9- <default>false</default>
10- <summary>Whether to enable Remote Login or not</summary>
11- </key>
12 </schema>
13 </schemalist>
14
15=== modified file 'src/settings.vala'
16--- src/settings.vala 2012-08-27 22:30:33 +0000
17+++ src/settings.vala 2012-09-17 18:00:47 +0000
18@@ -37,7 +37,6 @@
19 public static const string KEY_HIGH_CONTRAST = "high-contrast";
20 public static const string KEY_SCREEN_READER = "screen-reader";
21 public static const string KEY_PLAY_READY_SOUND = "play-ready-sound";
22- public static const string KEY_ENABLE_REMOTE_LOGIN = "enable-remote-login";
23
24 public static bool get_boolean (string key)
25 {
26
27=== modified file 'src/unity-greeter.vala'
28--- src/unity-greeter.vala 2012-09-04 14:45:06 +0000
29+++ src/unity-greeter.vala 2012-09-17 18:00:47 +0000
30@@ -247,6 +247,11 @@
31 return greeter.show_manual_login_hint;
32 }
33
34+ public bool show_remote_login_hint ()
35+ {
36+ return greeter.show_remote_login_hint;
37+ }
38+
39 public bool hide_users_hint ()
40 {
41 return greeter.hide_users_hint;
42
43=== modified file 'src/user-list.vala'
44--- src/user-list.vala 2012-09-17 17:12:13 +0000
45+++ src/user-list.vala 2012-09-17 18:00:47 +0000
46@@ -129,7 +129,8 @@
47
48 connect_to_lightdm ();
49
50- if (!UnityGreeter.singleton.test_mode && UGSettings.get_boolean (UGSettings.KEY_ENABLE_REMOTE_LOGIN))
51+ if (!UnityGreeter.singleton.test_mode &&
52+ UnityGreeter.singleton.show_remote_login_hint ())
53 remote_login_service_watch = Bus.watch_name (BusType.SESSION,
54 "com.canonical.RemoteLogin",
55 BusNameWatcherFlags.AUTO_START,
56
57=== modified file 'tests/unity-greeter.vala'
58--- tests/unity-greeter.vala 2012-09-05 13:25:39 +0000
59+++ tests/unity-greeter.vala 2012-09-17 18:00:47 +0000
60@@ -77,6 +77,11 @@
61 return false;
62 }
63
64+ public bool show_remote_login_hint ()
65+ {
66+ return true;
67+ }
68+
69 public bool hide_users_hint ()
70 {
71 return false;

Subscribers

People subscribed via source and target branches