Merge lp:~mterry/unity-greeter/kill-onboard into lp:unity-greeter

[Michael Terry]

It seems the kill code in ~MenuBar is never triggered. Instead, this branch emits a signal before actually starting the session, so that MenuBar knows when to cleanup.

Before this branch, I can reliably get an onboard crash report. With the branch, I don't.

=== modified file 'src/menubar.vala'
--- src/menubar.vala	2012-09-12 14:43:30 +0000
+++ src/menubar.vala	2012-09-24 19:15:24 +0000
@@ -166,9 +166,11 @@
         }
 
         setup_indicators ();
+
+        UnityGreeter.singleton.starting_session.connect (cleanup);
     }
 
-    ~MenuBar ()
+    public void cleanup ()
     {
         if (keyboard_pid != 0)
         {

=== modified file 'src/unity-greeter.vala'
--- src/unity-greeter.vala	2012-09-04 14:45:06 +0000
+++ src/unity-greeter.vala	2012-09-24 19:15:24 +0000
@@ -26,6 +26,7 @@
     public signal void show_message (string text, LightDM.MessageType type);
     public signal void show_prompt (string text, LightDM.PromptType type);
     public signal void authentication_complete ();
+    public signal void starting_session ();
 
     public bool test_mode = false;
 
@@ -161,6 +162,7 @@
         }
         else
         {
+            starting_session ();
             try
             {
                 greeter.start_session_sync (session);