Merge lp:~mterry/unity-greeter/keyboard-indicator into lp:unity-greeter
Proposed by
Michael Terry
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 244 | ||||
Proposed branch: | lp:~mterry/unity-greeter/keyboard-indicator | ||||
Merge into: | lp:unity-greeter | ||||
Diff against target: |
262 lines (+137/-26) 2 files modified
src/unity-greeter.vala (+27/-14) src/user-list.vala (+110/-12) |
||||
To merge this branch: | bzr merge lp:~mterry/unity-greeter/keyboard-indicator | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Approve | ||
Review via email: mp+86442@code.launchpad.net |
Description of the change
Adds a keyboard indicator. Requires a fix to lightdm first: https:/
To post a comment you must log in.
Hi,
I think this works nicely, for switching layout in the greeter.(I've tried it without updating lightdm, so I'm not sure if it was supposed to work, but it did.) But I think there are two issues with this patch:
First, I'm not sure it is a good idea to show all the keyboard layouts available in the system. If an administrator sets the system-wide layouts as some set of layouts, I think showing that set would be enough (or perhaps moving the rest of the layouts to a second level menu).
In addition, other system-wide settings related to keyboard layouts aren't honored, such as the layout switch key.
Currently it seems that you cannot set system-wide settings graphically (see bug #854714), but you could still have such settings when upgrading from a previous release, or maybe using console-setup configuration.