lp:~mterry/unity-greeter/average-color

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity-greeter at revision 547

Robert Ancell: Approve on 2012-08-30

Diff: 205 lines (+162/-0)

1 file modified

src/background.vala (+162/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1043572: Shade notification colors according to current background

Low

Fix Released

Link a bug report

Related blueprints

546. By Michael Terry on 2012-08-30

Calculate average color of background for the benefit of notify-osd

545. By Michael Terry on 2012-08-29

ignore notifications for focus purposes

544. By Launchpad Translations on behalf of unity-greeter-team on 2012-08-29

Launchpad automatic translations update.

543. By Michael Terry on 2012-08-28

Revert "remove dead code" by Robert

This is needed to match dbus API of the methods

Otherwise you get

[+18.36s] CRITICAL: g_variant_get_variant: assertion `g_variant_is_of_type (value, G_VARIANT_TYPE_VARIANT)' failed
[+18.36s] CRITICAL: g_variant_iter_loop: assertion `g_variant_is_of_type (GVSI(iter)->value, G_VARIANT_TYPE_ARRAY)' failed
[+18.36s] CRITICAL: g_variant_get_variant: assertion `g_variant_is_of_type (value, G_VARIANT_TYPE_VARIANT)' failed
[+18.36s] CRITICAL: g_variant_iter_loop: assertion `g_variant_is_of_type (GVSI(iter)->value, G_VARIANT_TYPE_ARRAY)' failed
[+18.36s] CRITICAL: g_variant_get_variant: assertion `g_variant_is_of_type (value, G_VARIANT_TYPE_VARIANT)' failed
[+18.36s] CRITICAL: g_variant_iter_loop: assertion `g_variant_is_of_type (GVSI(iter)->value, G_VARIANT_TYPE_ARRAY)' failed

But with the unused DBus bits back, you get warnings, which Robert was trying
to avoid. So mark those DBus structs as protected to shut the compiler up,
and fix some array usage that vala does not allow on public/protected fields.

542. By Launchpad Translations on behalf of unity-greeter-team on 2012-08-28

Launchpad automatic translations update.

541. By Robert Ancell on 2012-08-27

More code style fixing including liberal use of 'var'

540. By Robert Ancell on 2012-08-27

Use a standard Gtk.MessageDialog for the remote account dialog

539. By Robert Ancell on 2012-08-27

Don't use deprecated Gtk.HBox, Gtk.VBox

538. By Robert Ancell on 2012-08-27

Remove dead code

537. By Robert Ancell on 2012-08-27

Fix coding style