Merge lp:~mterry/unity-2d/relicense into lp:unity-2d/3.0

Proposed by Michael Terry
Status: Merged
Approved by: Florian Boucault
Approved revision: 396
Merged at revision: 378
Proposed branch: lp:~mterry/unity-2d/relicense
Merge into: lp:unity-2d/3.0
Diff against target: 300 lines (+83/-131)
6 files modified
debian/copyright (+61/-105)
panel/lib/applet.cpp (+3/-3)
panel/lib/applet.h (+3/-3)
panel/lib/debug_p.h (+10/-14)
panel/lib/panel.cpp (+3/-3)
panel/lib/panel.h (+3/-3)
To merge this branch: bzr merge lp:~mterry/unity-2d/relicense
Reviewer Review Type Date Requested Status
Florian Boucault (community) Approve
Review via email: mp+47720@code.launchpad.net

Description of the change

According to the GPL [1], you cannot actually distribute LGPL code that is actually part of a GPL binary (vs linked to). The bits of Unity 2D that are LGPL should instead be distributed as GPL-3. The GPL-2+ bits are fine to leave as-is.

I also converted debian/copyright to DEP5 while I was there.

[1] http://www.gnu.org/licenses/gpl-faq.html#AllCompatibility

To post a comment you must log in.
lp:~mterry/unity-2d/relicense updated
395. By Michael Terry

fix typo

Revision history for this message
Florian Boucault (fboucault) wrote :

Thanks for the great heads up Michael! It's really appreciated and looks really good. Just one thing needs fixing: the copyright headers modified were not adapted entirely as it shows here:

kaleo@tequila:~/Projects/upicek/unity-2d$ grep -r Lesser *

panel/lib/applet.h: * GNU Lesser General Public License for more details.
panel/lib/debug_p.h: GNU Lesser General Public License for more details.
panel/lib/applet.cpp: * GNU Lesser General Public License for more details.
panel/lib/panel.h: * GNU Lesser General Public License for more details.
panel/lib/panel.cpp: * GNU Lesser General Public License for more details.

review: Needs Fixing
Revision history for this message
Michael Terry (mterry) wrote :

Ah, good catch. Fixed now.

lp:~mterry/unity-2d/relicense updated
396. By Michael Terry

whoops, missed some instances of 'Lesser', thanks Florian

Revision history for this message
Florian Boucault (fboucault) wrote :

Good to go! (tarmac will merge automatically)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/copyright'
2--- debian/copyright 2011-01-27 22:04:48 +0000
3+++ debian/copyright 2011-01-28 13:33:42 +0000
4@@ -1,106 +1,62 @@
5-This package was debianized by Olivier Tilloy <olivier.tilloy@canonical.com>
6-on Mon, 30 Aug 2010 14:56:59 +0200
7-
8-It was downloaded from:
9-
10- <https://code.launchpad.net/~unity-2d-team/unity-2d/trunk>
11-
12-Upstream Author(s):
13-
14- Florian Boucault <florian.boucault@canonical.com>
15- Olivier Tilloy <olivier.tilloy@canonical.com>
16- Aurélien Gâteau <aurelien.gateau@canonical.com>
17-
18-Copyright:
19-
20- Copyright (C) 2010 Canonical Ltd.
21-
22-License:
23-
24- This program is free software: you can redistribute it and/or modify
25- it under the terms of the GNU General Public License as published by
26- the Free Software Foundation, version 3.
27-
28- This package is distributed in the hope that it will be useful,
29- but WITHOUT ANY WARRANTY; without even the implied warranty of
30- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
31- GNU General Public License for more details.
32-
33- You should have received a copy of the GNU General Public License
34- along with this program. If not, see <http://www.gnu.org/licenses/>.
35-
36-On Debian systems, the complete text of the GNU General
37-Public License version 3 can be found in `/usr/share/common-licenses/GPL-3'.
38-
39-The following files are licensed under the GNU General Public License
40-version 2:
41-
42-panel/applets/indicator/indicator.h
43-panel/applets/indicator/indicator.c
44-panel/applets/legacytray/fdoselectionmanager.c
45-panel/applets/legacytray/fdoselectionmanager.h
46-panel/applets/legacytray/x11embedpainter.cpp
47-panel/applets/legacytray/x11embedpainter.h
48-panel/applets/legacytray/x11embeddelegate.cpp
49-panel/applets/legacytray/x11embeddelegate.h
50-panel/applets/legacytray/x11embedcontainer.cpp
51-panel/applets/legacytray/x11embedcontainer.h
52-
53- This program is free software: you can redistribute it and/or modify
54- it under the terms of the GNU General Public License as published by
55- the Free Software Foundation, either version 2 of the License, or
56- (at your option) any later version.
57-
58- This package is distributed in the hope that it will be useful,
59- but WITHOUT ANY WARRANTY; without even the implied warranty of
60- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
61- GNU General Public License for more details.
62-
63- You should have received a copy of the GNU General Public License
64- along with this program. If not, see <http://www.gnu.org/licenses/>.
65-
66-On Debian systems, the complete text of the GNU General
67-Public License version 2 can be found in `/usr/share/common-licenses/GPL-2'.
68-
69-Individual parts of this package are licensed under the GNU Lesser General Public
70-3 License:
71-
72- This program is free software: you can redistribute it and/or modify
73- it under the terms of the GNU Lesser General Public License as
74- published by the Free Software Foundation, version 3.
75-
76- This package is distributed in the hope that it will be useful,
77- but WITHOUT ANY WARRANTY; without even the implied warranty of
78- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
79- GNU Lesser General Public License for more details.
80-
81- You should have received a copy of the GNU Lesser General Public License
82- along with this program. If not, see <http://www.gnu.org/licenses/>.
83-
84-On Debian systems, the complete text of the GNU General
85-Public License version 3 can be found in `/usr/share/common-licenses/LGPL-3'.
86-
87-The file panel/lib/debug_p.h licensed under the GNU Library General Public
88-2.1 License :
89-
90- This program is free software: you can redistribute it and/or modify
91- it under the terms of the GNU Library General Public License as
92- published by the Free Software Foundation, version 2.
93-
94- This package is distributed in the hope that it will be useful,
95- but WITHOUT ANY WARRANTY; without even the implied warranty of
96- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
97- GNU Library General Public License for more details.
98-
99- You should have received a copy of the GNU Library General Public License
100- along with this program. If not, see <http://www.gnu.org/licenses/>
101-
102-On Debian systems, the complete text of the GNU General
103-Public License version 2 can be found in `/usr/share/common-licenses/LGPL-2'.
104-
105-The Debian packaging is:
106-
107- Copyright (C) 2010 Canonical Ltd.
108-
109-and is licensed under the GPL version 3, see above.
110+Format: http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=166
111+Upstream-Name: Unity 2D
112+Source: https://code.launchpad.net/~unity-2d-team/unity-2d/trunk
113+License: GPL-3
114+
115+Files: *
116+Copyright: 2009,2010 Canonical Ltd.
117+License: GPL-3
118+
119+Files: panel/applets/indicator/indicator.c
120+ panel/applets/indicator/indicator.h
121+Copyright: 2009 Mark Trompell <mark@foresightlinux.org>
122+License: GPL-2+
123+
124+Files: panel/applets/legacytray/fdoselectionmanager.cpp
125+ panel/applets/legacytray/fdoselectionmanager.h
126+ panel/applets/legacytray/x11embedpainter.cpp
127+ panel/applets/legacytray/x11embedpainter.h
128+ panel/applets/legacytray/x11embeddelegate.cpp
129+ panel/applets/legacytray/x11embeddelegate.h
130+ panel/applets/legacytray/x11embedcontainer.cpp
131+ panel/applets/legacytray/x11embedcontainer.h
132+Copyright: 2008 Jason Stubbs <jasonbstubbs@gmail.com>
133+License: GPL-2+
134+
135+Files: debian/*
136+Copyright: 2010 Canonical Ltd.
137+License: GPL-3
138+
139+License: GPL-2+
140+ This program is free software: you can redistribute it and/or modify
141+ it under the terms of the GNU General Public License as published by
142+ the Free Software Foundation, either version 2 of the License, or
143+ (at your option) any later version.
144+ .
145+ This program is distributed in the hope that it will be useful,
146+ but WITHOUT ANY WARRANTY; without even the implied warranty of
147+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
148+ GNU General Public License for more details.
149+ .
150+ You should have received a copy of the GNU General Public License
151+ along with this program. If not, see <http://www.gnu.org/licenses/>.
152+ .
153+ On Debian systems, the full text of the GNU General Public License
154+ version 2 can be found in the file /usr/share/common-licenses/GPL-2.
155+
156+License: GPL-3
157+ This program is free software: you can redistribute it and/or modify
158+ it under the terms of the GNU General Public License as published by
159+ the Free Software Foundation, version 3 of the License.
160+ .
161+ This program is distributed in the hope that it will be useful,
162+ but WITHOUT ANY WARRANTY; without even the implied warranty of
163+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
164+ GNU General Public License for more details.
165+ .
166+ You should have received a copy of the GNU General Public License
167+ along with this program. If not, see <http://www.gnu.org/licenses/>.
168+ .
169+ On Debian systems, the full text of the GNU General Public License
170+ version 3 can be found in the file /usr/share/common-licenses/GPL-3.
171
172
173=== modified file 'panel/lib/applet.cpp'
174--- panel/lib/applet.cpp 2011-01-15 01:41:03 +0000
175+++ panel/lib/applet.cpp 2011-01-28 13:33:42 +0000
176@@ -7,15 +7,15 @@
177 * - Aurélien Gâteau <aurelien.gateau@canonical.com>
178 *
179 * This program is free software; you can redistribute it and/or modify
180- * it under the terms of the GNU Lesser General Public License as published
181+ * it under the terms of the GNU General Public License as published
182 * by the Free Software Foundation; version 3.
183 *
184 * This program is distributed in the hope that it will be useful,
185 * but WITHOUT ANY WARRANTY; without even the implied warranty of
186 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
187- * GNU Lesser General Public License for more details.
188+ * GNU General Public License for more details.
189 *
190- * You should have received a copy of the GNU Lesser General Public License
191+ * You should have received a copy of the GNU General Public License
192 * along with this program. If not, see <http://www.gnu.org/licenses/>.
193 */
194
195
196=== modified file 'panel/lib/applet.h'
197--- panel/lib/applet.h 2011-01-15 01:41:03 +0000
198+++ panel/lib/applet.h 2011-01-28 13:33:42 +0000
199@@ -7,15 +7,15 @@
200 * - Aurélien Gâteau <aurelien.gateau@canonical.com>
201 *
202 * This program is free software; you can redistribute it and/or modify
203- * it under the terms of the GNU Lesser General Public License as published
204+ * it under the terms of the GNU General Public License as published
205 * by the Free Software Foundation; version 3.
206 *
207 * This program is distributed in the hope that it will be useful,
208 * but WITHOUT ANY WARRANTY; without even the implied warranty of
209 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
210- * GNU Lesser General Public License for more details.
211+ * GNU General Public License for more details.
212 *
213- * You should have received a copy of the GNU Lesser General Public License
214+ * You should have received a copy of the GNU General Public License
215 * along with this program. If not, see <http://www.gnu.org/licenses/>.
216 */
217
218
219=== modified file 'panel/lib/debug_p.h'
220--- panel/lib/debug_p.h 2010-10-06 13:52:55 +0000
221+++ panel/lib/debug_p.h 2011-01-28 13:33:42 +0000
222@@ -1,23 +1,19 @@
223-/* This file is part of the dbusmenu-qt library
224+/* This file is part of unity-2d
225 Copyright 2009 Canonical
226 Author: Aurelien Gateau <aurelien.gateau@canonical.com>
227
228- This library is free software; you can redistribute it and/or
229- modify it under the terms of the GNU Library General Public
230- License (LGPL) as published by the Free Software Foundation;
231- either version 2 of the License, or (at your option) any later
232- version.
233+ This program is free software; you can redistribute it and/or modify
234+ it under the terms of the GNU General Public License as published
235+ by the Free Software Foundation; version 3.
236
237- This library is distributed in the hope that it will be useful,
238+ This program is distributed in the hope that it will be useful,
239 but WITHOUT ANY WARRANTY; without even the implied warranty of
240- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
241- Library General Public License for more details.
242+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
243+ GNU General Public License for more details.
244
245- You should have received a copy of the GNU Library General Public License
246- along with this library; see the file COPYING.LIB. If not, write to
247- the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
248- Boston, MA 02110-1301, USA.
249-*/
250+ You should have received a copy of the GNU General Public License
251+ along with this program. If not, see <http://www.gnu.org/licenses/>.
252+ */
253 #ifndef DEBUG_P_H
254 #define DEBUG_P_H
255
256
257=== modified file 'panel/lib/panel.cpp'
258--- panel/lib/panel.cpp 2011-01-15 01:41:03 +0000
259+++ panel/lib/panel.cpp 2011-01-28 13:33:42 +0000
260@@ -7,15 +7,15 @@
261 * - Aurélien Gâteau <aurelien.gateau@canonical.com>
262 *
263 * This program is free software; you can redistribute it and/or modify
264- * it under the terms of the GNU Lesser General Public License as published
265+ * it under the terms of the GNU General Public License as published
266 * by the Free Software Foundation; version 3.
267 *
268 * This program is distributed in the hope that it will be useful,
269 * but WITHOUT ANY WARRANTY; without even the implied warranty of
270 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
271- * GNU Lesser General Public License for more details.
272+ * GNU General Public License for more details.
273 *
274- * You should have received a copy of the GNU Lesser General Public License
275+ * You should have received a copy of the GNU General Public License
276 * along with this program. If not, see <http://www.gnu.org/licenses/>.
277 */
278
279
280=== modified file 'panel/lib/panel.h'
281--- panel/lib/panel.h 2011-01-15 01:41:03 +0000
282+++ panel/lib/panel.h 2011-01-28 13:33:42 +0000
283@@ -7,15 +7,15 @@
284 * - Aurélien Gâteau <aurelien.gateau@canonical.com>
285 *
286 * This program is free software; you can redistribute it and/or modify
287- * it under the terms of the GNU Lesser General Public License as published
288+ * it under the terms of the GNU General Public License as published
289 * by the Free Software Foundation; version 3.
290 *
291 * This program is distributed in the hope that it will be useful,
292 * but WITHOUT ANY WARRANTY; without even the implied warranty of
293 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
294- * GNU Lesser General Public License for more details.
295+ * GNU General Public License for more details.
296 *
297- * You should have received a copy of the GNU Lesser General Public License
298+ * You should have received a copy of the GNU General Public License
299 * along with this program. If not, see <http://www.gnu.org/licenses/>.
300 */
301

Subscribers

People subscribed via source and target branches