Merge lp:~mterry/ubuntuone-couch/no-ssl-validation into lp:ubuntuone-couch

[Michael Terry]

See bug 797281 for details.

[dobey (dobey)]

Interesting. I'm not sure we should go this "temporary workaround" route by explicitly disabling cert validation, rather than just fixing it so that cert validation works.

Can we either pass in the path to the correct cert file to check against, or somehow fix installation of the CA certs we have to provide in ubuntuone-storage-protocol to be automatically loaded by everything? We will need to change package level dependencies either way, but I think it's the right thing to do, and not much more work. Or is it an insane amount of work to do that?

review: Needs Information

[Michael Terry (mterry)]

Yes, by all means let's fix it the right way. I was just proposing a way to unblock functionality until this was fixed correctly.

I'm not sure about the Right Way to fix it. SSL certs are black magic to me.

[John O'Brien (jdobrien)]

This is really old, please confirm that it's still needed.

review: Needs Information

[Michael Terry (mterry)]

Indeed, this is not needed anymore. httplib2 seems fixed.

Unmerged revisions

14. By Michael Terry on 2011-06-21

don't validate ssl certficates

=== modified file 'ubuntuone/couch/auth.py'
--- ubuntuone/couch/auth.py	2011-05-25 14:04:22 +0000
+++ ubuntuone/couch/auth.py	2011-06-21 17:55:19 +0000
@@ -138,6 +138,6 @@
         consumer, token, url, http_method, signature_method, parameters)
     headers = headers or {}
     headers.update(oauth_header)
-    http = httplib2.Http(timeout=10)
+    http = httplib2.Http(timeout=10, disable_ssl_certificate_validation=True)
     return http.request(
         url, method=http_method, headers=headers, body=request_body)