Merge lp:~mterry/ubuntu-touch-session/no-lightdm-session into lp:ubuntu-touch-session

Proposed by Michael Terry
Status: Merged
Approved by: Michał Sawicz
Approved revision: 184
Merged at revision: 185
Proposed branch: lp:~mterry/ubuntu-touch-session/no-lightdm-session
Merge into: lp:ubuntu-touch-session
Diff against target: 52 lines (+14/-1)
4 files modified
52-ubuntu-touch.conf (+1/-0)
debian/control (+1/-1)
debian/ubuntu-touch-session.install (+1/-0)
ubuntu-touch-lightdm-session (+11/-0)
To merge this branch: bzr merge lp:~mterry/ubuntu-touch-session/no-lightdm-session
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
Review via email: mp+221891@code.launchpad.net

Commit message

Don't run lightdm-session if using a Mir session.

Description of the change

Don't run lightdm-session if using a Mir session.

/usr/sbin/lightdm-session is a wrapper for user sessions that LightDM uses to set up a bunch of X stuff. But in Mir, we don't want that.

Having it run for Mir meant that with dbus-x11 installed, we'd get a second dbus daemon in the user shell which is confusing autopilot tests.

To post a comment you must log in.
184. By Michael Terry

Version dep on unity8-greeter

Revision history for this message
Michał Sawicz (saviq) wrote :

Kk.

review: Approve
185. By Michael Terry

Merge from trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '52-ubuntu-touch.conf'
2--- 52-ubuntu-touch.conf 2014-04-03 18:53:19 +0000
3+++ 52-ubuntu-touch.conf 2014-06-04 15:16:45 +0000
4@@ -1,6 +1,7 @@
5 [SeatDefaults]
6 type=unity
7 user-session=ubuntu-touch
8+session-wrapper=/usr/sbin/ubuntu-touch-lightdm-session
9 unity-compositor-command=/usr/share/ubuntu-touch-session/usc-wrapper
10 autologin-in-background=true
11
12
13=== modified file 'debian/control'
14--- debian/control 2014-06-01 20:44:44 +0000
15+++ debian/control 2014-06-04 15:16:45 +0000
16@@ -13,7 +13,7 @@
17 Architecture: all
18 Depends: lightdm (>= 1.9.5),
19 unity-system-compositor (>= 0.0.3),
20- unity8-greeter,
21+ unity8-greeter (>= 7.88),
22 ubuntu-app-launch (>= 0.1+13.10.20130923.4-0ubuntu1~),
23 ${misc:Depends},
24 ${shlibs:Depends},
25
26=== modified file 'debian/ubuntu-touch-session.install'
27--- debian/ubuntu-touch-session.install 2014-05-12 16:21:05 +0000
28+++ debian/ubuntu-touch-session.install 2014-06-04 15:16:45 +0000
29@@ -4,6 +4,7 @@
30 *.override /etc/init
31 ubuntu-touch-session.d/* /etc/ubuntu-touch-session.d/
32 upstart-session/* /usr/share/upstart/sessions/
33+ubuntu-touch-lightdm-session /usr/sbin/
34 ubuntu-touch-session /usr/bin/
35 ubuntu-touch.desktop /usr/share/lightdm/sessions
36 52-ubuntu-touch.conf /usr/share/lightdm/lightdm.conf.d
37
38=== added file 'ubuntu-touch-lightdm-session'
39--- ubuntu-touch-lightdm-session 1970-01-01 00:00:00 +0000
40+++ ubuntu-touch-lightdm-session 2014-06-04 15:16:45 +0000
41@@ -0,0 +1,11 @@
42+#!/bin/sh
43+
44+# /usr/sbin/lightdm-session is very X specific. We don't want it for Ubuntu
45+# Touch's Mir sessions. So determine if we are running Mir or X and do the
46+# right thing. Ideally LightDM would do this for us, but in the meantime...
47+
48+if [ -n "$MIR_SOCKET" ]; then
49+ exec $@
50+else
51+ exec /usr/sbin/lightdm-session $@
52+fi

Subscribers

People subscribed via source and target branches