Merge lp:~mterry/ubuntu-release-upgrader/resize-view into lp:ubuntu-release-upgrader

Proposed by Michael Terry
Status: Merged
Merged at revision: 2583
Proposed branch: lp:~mterry/ubuntu-release-upgrader/resize-view
Merge into: lp:ubuntu-release-upgrader
Diff against target: 53 lines (+4/-6)
1 file modified
data/gtkbuilder/DistUpgrade.ui (+4/-6)
To merge this branch: bzr merge lp:~mterry/ubuntu-release-upgrader/resize-view
Reviewer Review Type Date Requested Status
Brian Murray Approve
Review via email: mp+130195@code.launchpad.net

Description of the change

Size the conffile diff dialog better.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

(See test script in bug)

Revision history for this message
Brian Murray (brian-murray) wrote :

Looks good to me thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/gtkbuilder/DistUpgrade.ui'
2--- data/gtkbuilder/DistUpgrade.ui 2012-06-28 16:12:09 +0000
3+++ data/gtkbuilder/DistUpgrade.ui 2012-10-17 19:19:37 +0000
4@@ -287,7 +287,6 @@
5 <object class="GtkDialog" id="dialog_conffile">
6 <property name="can_focus">False</property>
7 <property name="border_width">5</property>
8- <property name="resizable">False</property>
9 <property name="modal">True</property>
10 <property name="window_position">center-on-parent</property>
11 <property name="type_hint">dialog</property>
12@@ -446,6 +445,7 @@
13 <property name="spacing">12</property>
14 <child>
15 <object class="GtkLabel" id="label_conffile">
16+ <property name="width_chars">60</property>
17 <property name="visible">True</property>
18 <property name="can_focus">False</property>
19 <property name="xalign">0</property>
20@@ -482,12 +482,12 @@
21 <property name="can_focus">False</property>
22 <child>
23 <object class="GtkScrolledWindow" id="scrolledwindow5">
24+ <property name="height_request">200</property>
25 <property name="visible">True</property>
26 <property name="can_focus">True</property>
27 <property name="shadow_type">in</property>
28 <child>
29 <object class="GtkTextView" id="textview_conffile">
30- <property name="height_request">300</property>
31 <property name="visible">True</property>
32 <property name="can_focus">True</property>
33 <property name="editable">False</property>
34@@ -496,8 +496,7 @@
35 </child>
36 </object>
37 <packing>
38- <property name="expand">False</property>
39- <property name="fill">False</property>
40+ <property name="expand">True</property>
41 <property name="position">0</property>
42 </packing>
43 </child>
44@@ -512,8 +511,7 @@
45 </child>
46 </object>
47 <packing>
48- <property name="expand">False</property>
49- <property name="fill">True</property>
50+ <property name="expand">True</property>
51 <property name="position">2</property>
52 </packing>
53 </child>

Subscribers

People subscribed via source and target branches