Merge lp:~mterry/timezonemap/alternate-names into lp:timezonemap
Status: | Approved | ||||
---|---|---|---|---|---|
Approved by: | Mathieu Trudel-Lapierre | ||||
Approved revision: | 59 | ||||
Proposed branch: | lp:~mterry/timezonemap/alternate-names | ||||
Merge into: | lp:timezonemap | ||||
Diff against target: |
330 lines (+184/-24) 6 files modified
configure.ac (+1/-1) debian/changelog (+6/-0) src/cc-timezone-location.c (+68/-0) src/cc-timezone-location.h (+4/-0) src/test-timezone.c (+100/-23) src/tz.c (+5/-0) |
||||
To merge this branch: | bzr merge lp:~mterry/timezonemap/alternate-names | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mathieu Trudel-Lapierre | Approve | ||
Review via email:
|
Commit message
Exposes the "alternate_names" and "en_name_utf8" fields from the cities database.
Description of the change
This branch exposes the "alternate_names" and "en_name_utf8" fields from the cities database.
My rationale here is enabling the unity8 out-of-box wizard to search on native-language city names.
Ideally, we could use the alternateNames.txt database, but that is 400MB uncompressed, and we probably don't want to add that to the images. (If we did use that, we could add an API like get_localized_
But failing that, cities15000.txt has a short list of alternate names (without noting which language each name is in). I've exposed that here, so that clients can search across all possible language strings.
While doing that, I noticed that our en_name field was using the ascii name. I considered just upgrading it to the utf8 version, but guessed that you folks wouldn't like that change in behavior. So I exposed the utf8 version too (makes for a better display value).
Unmerged revisions
- 59. By Michael Terry
-
Bump version
- 58. By Michael Terry
-
Add new field en_name_utf8 rather than upgrading en_name in place
- 57. By Michael Terry
-
Expose alternate_names from cities database
LGTM