Merge lp:~mterry/telephony-service/start-on into lp:telephony-service

[Michael Terry]

Tie telephony-service-indicator lifecycle to indicator-messages.

Tie telephony-service-indicator lifecycle to indicator-messages.

The current upstart job just does "start on started unity8". But I noticed that in testing my split greeter branches, the messaging indicator wasn't showing in unity8-greeter (because unity8 isn't present in that session, so telephony-service-indicator never started, so indicator-messages stayed hidden).

I think it makes more sense to switch to starting and stopping based on indicator-messages being up, yeah? Else if you want to continue being explicit, we have a unity8-greeter-started signal you could base off of.

== Checklist ==

Are there any related MPs required for this MP to build/function as expected? Please list.
- No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
- Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
- Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
- Didn't try, but I confirmed that it came up as expected in both a normal session and a greeter session. Full test suite seemed overkill for this.

If you changed the UI, was the change specified/approved by design?
- NA

If you changed the packaging (debian), did you subscribe a core-dev to this MP?
-NA

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:806
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/173/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-trusty-amd64-ci/98
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-trusty-armhf-ci/101
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-trusty-armhf-ci/101/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-trusty-i386-ci/97

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/173/rebuild

review: Approve (continuous-integration)

[Michael Terry (mterry)]

I realized that maybe the goal of "started unity8" was to only run in Touch. If so, then maybe do the same thing that indicator-network did:

pre-start script
        # NOTE: Only used on Unity8 today, not 7
        if [ "x$DESKTOP_SESSION" != "xubuntu-touch" ] ; then
                stop; exit 0
        fi
end script

[Oliver Grawert (ogra)]

better try:

start on started indicator-messages and (xsession SESSION=ubuntu-touch)

that will prevent you from spawning an extra shell and slowing down the startup ...

[Michael Terry (mterry)]

Poke! This is a blocker for landing the split greeter feature.

[Gustavo Pichorim Boiko (boiko)]

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

=== modified file 'upstart/telephony-service-indicator.conf'
--- upstart/telephony-service-indicator.conf	2014-03-24 18:53:27 +0000
+++ upstart/telephony-service-indicator.conf	2014-04-18 21:22:12 +0000
@@ -1,8 +1,8 @@
 description "telephony-service-indicator"
 author "Tiago Salem Herrmann <[e-mail]>"
 
-start on started unity8
-stop on session-end
+start on started indicator-messages
+stop on stopping indicator-messages
 
 respawn