Snappy

Code review comment for lp:~mterry/snappy/systemd-restart-15.04

systemd-restart-15.04
Merge into 15.04-deprecated

Revision history for this message

Snappy Tarmac (snappydevtarmac) wrote on 2015-07-06:

The attempt to merge lp:~mterry/snappy/systemd-restart-15.04 into lp:snappy/15.04 failed. Below is the output from the failed tests.

Checking formatting
Installing godeps
Install golint
Obtaining dependencies
update code.google.com/p/go.crypto failed; trying to fetch newer version
update github.com/blakesmith/ar failed; trying to fetch newer version
code.google.com/p/go.crypto now at 69e2a90ed92d03812364aeb947b7068dc42e561e
update github.com/cheggaaa/pb failed; trying to fetch newer version
github.com/blakesmith/ar now at c9a977dd0cc1392b023382c7bfa5a22af8d3b730
update github.com/jessevdk/go-flags failed; trying to fetch newer version
github.com/cheggaaa/pb now at e8c7cc515bfde3e267957a3b110080ceed51354e
update github.com/juju/loggo failed; trying to fetch newer version
github.com/jessevdk/go-flags now at 15347ef417a300349807983f15af9e65cd2e1b3a
update github.com/mvo5/goconfigparser failed; trying to fetch newer version
github.com/juju/loggo now at 4c7cbce140ca070eeb59a28f4bf9507e511711f9
update gopkg.in/yaml.v2 failed; trying to fetch newer version
github.com/mvo5/goconfigparser now at 26426272dda20cc76aa1fa44286dc743d2972fe8
update launchpad.net/gocheck failed; trying to fetch newer version
gopkg.in/yaml.v2 now at 49c95bdc21843256fb6c4e0d370a05f24a0bf213
launchpad.net/gocheck now at <email address hidden>
Building
Running tests from /home/tarmac/tmp/tmp.mz0bcXNGo4/src/launchpad.net/snappy
=== RUN Test
OK: 10 passed
--- PASS: Test (0.34 seconds)
PASS
coverage: 79.3% of statements
ok launchpad.net/snappy/clickdeb 0.346s coverage: 79.3% of statements
=== RUN Test
OK: 6 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 12.7% of statements
ok launchpad.net/snappy/cmd/snappy 0.019s coverage: 12.7% of statements
=== RUN Test
OK: 24 passed
--- PASS: Test (0.08 seconds)
PASS
coverage: 100.0% of statements
ok launchpad.net/snappy/coreconfig 0.087s coverage: 100.0% of statements
=== RUN Test
OK: 33 passed
--- PASS: Test (1.69 seconds)
PASS
coverage: 74.0% of statements
ok launchpad.net/snappy/helpers 1.697s coverage: 74.0% of statements
=== RUN Test
OK: 7 passed
--- PASS: Test (0.05 seconds)
PASS
coverage: 92.5% of statements
ok launchpad.net/snappy/logger 0.063s coverage: 92.5% of statements
=== RUN Test
OK: 38 passed
--- PASS: Test (0.18 seconds)
PASS
coverage: 82.2% of statements
ok launchpad.net/snappy/partition 0.190s coverage: 82.2% of statements
=== RUN Test
OK: 12 passed
--- PASS: Test (0.09 seconds)
PASS
coverage: 87.8% of statements
ok launchpad.net/snappy/policy 0.094s coverage: 87.8% of statements
=== RUN Test
OK: 3 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 84.8% of statements
ok launchpad.net/snappy/priv 0.005s coverage: 84.8% of statements
=== RUN Test
OK: 4 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 50.0% of statements
ok launchpad.net/snappy/progress 0.009s coverage: 50.0% of statements
=== RUN Test
OK: 6 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 100.0% of statements
ok launchpad.net/snappy/release 0.010s coverage: 100.0% of statements
=== RUN Test
2015-07-06 18:43:42 ERROR snappy logger.go:199 hello-app.potato failed to install: a package by that name is already installed
2015-07-06 18:43:42 ERROR snappy logger.go:199 foo failed to install: the given snap is already installed
foo foo-fork
2015/07/06 14:43:42 Use of deprecated "framework" key in yaml
2015/07/06 14:43:42 Use of deprecated "framework" key in yaml
2015/07/06 14:43:42 WARNING: Skipping hook apparmor
2015/07/06 14:43:42 WARNING: Skipping hook apparmor
2015/07/06 14:43:42 WARNING: Skipping hook apparmor
2015/07/06 14:43:47 WARNING: Skipping hook apparmor
2015/07/06 14:43:47 WARNING: Skipping hook apparmor
2015/07/06 14:43:47 WARNING: Skipping hook apparmor
2015/07/06 14:43:47 WARNING: Skipping hook apparmor
2015/07/06 14:43:47 WARNING: Skipping hook apparmor
2015-07-06 18:43:48 ERROR snappy logger.go:199 snappy package cannot be removed
2015-07-06 18:43:48 ERROR snappy logger.go:199 snappy package cannot be removed
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
OK: 248 passed
--- PASS: Test (7.30 seconds)
PASS
coverage: 79.2% of statements
ok launchpad.net/snappy/snappy 7.313s coverage: 79.2% of statements
=== RUN Test
OK: 12 passed
--- PASS: Test (0.52 seconds)
PASS
coverage: 79.3% of statements
ok launchpad.net/snappy/systemd 0.524s coverage: 79.3% of statements
Running vet
Running lint
Lint complains:
cmd/snappy/cmd_internal_unpack.go:70:6: func readUid should be readUID helpers/touch.go:39:5: exported var ErrNotAbsPath should have comment or be unexported

# we always run in a fresh dir in tarmac
export GOPATH=$(mktemp -d)
trap 'rm -rf "$GOPATH"' EXIT

# this is a hack, but not sure tarmac is golang friendly
mkdir -p $GOPATH/src/launchpad.net/snappy
cp -a . $GOPATH/src/launchpad.net/snappy/
cd $GOPATH/src/launchpad.net/snappy

./run-checks

if which goctest >/dev/null; then
goctest="goctest"
else
goctest="go test"
fi

echo Checking formatting
fmt=$(gofmt -l .)

if [ -n "$fmt" ]; then
    echo "Formatting wrong in following files"
    echo $fmt
    exit 1
fi

echo Installing godeps
go get launchpad.net/godeps
export PATH=$PATH:$GOPATH/bin

echo Install golint
go get github.com/golang/lint/golint
export PATH=$PATH:$GOPATH/bin

echo Obtaining dependencies
godeps -u dependencies.tsv

echo Building
go build -v launchpad.net/snappy/...
github.com/blakesmith/ar
github.com/juju/loggo
code.google.com/p/go.crypto/ssh/terminal
launchpad.net/snappy/logger
github.com/jessevdk/go-flags
launchpad.net/snappy/helpers
launchpad.net/snappy/priv
github.com/cheggaaa/pb
launchpad.net/snappy/progress
launchpad.net/snappy/clickdeb
github.com/mvo5/goconfigparser
gopkg.in/yaml.v2
launchpad.net/snappy/policy
launchpad.net/snappy/release
launchpad.net/snappy/systemd
launchpad.net/snappy/coreconfig
launchpad.net/snappy/partition
launchpad.net/snappy/snappy
launchpad.net/snappy/cmd/snappy

# tests
echo Running tests from $(pwd)
$goctest -v -cover ./...

# go vet
echo Running vet
go vet ./...

# golint
echo Running lint
lint=$(golint ./...)
if [ -n "$lint" ]; then
    echo "Lint complains:"
    echo $lint
    exit 1
fi

The attempt to merge lp:~mterry/snappy/systemd-restart-15.04 into lp:snappy/15.04 failed. Below is the output from the failed tests.

Checking formatting
Installing godeps
Install golint
Obtaining dependencies
update code.google.com/p/go.crypto failed; trying to fetch newer version
update github.com/blakesmith/ar failed; trying to fetch newer version
code.google.com/p/go.crypto now at 69e2a90ed92d03812364aeb947b7068dc42e561e
update github.com/cheggaaa/pb failed; trying to fetch newer version
github.com/blakesmith/ar now at c9a977dd0cc1392b023382c7bfa5a22af8d3b730
update github.com/jessevdk/go-flags failed; trying to fetch newer version
github.com/cheggaaa/pb now at e8c7cc515bfde3e267957a3b110080ceed51354e
update github.com/juju/loggo failed; trying to fetch newer version
github.com/jessevdk/go-flags now at 15347ef417a300349807983f15af9e65cd2e1b3a
update github.com/mvo5/goconfigparser failed; trying to fetch newer version
github.com/juju/loggo now at 4c7cbce140ca070eeb59a28f4bf9507e511711f9
update gopkg.in/yaml.v2 failed; trying to fetch newer version
github.com/mvo5/goconfigparser now at 26426272dda20cc76aa1fa44286dc743d2972fe8
update launchpad.net/gocheck failed; trying to fetch newer version
gopkg.in/yaml.v2 now at 49c95bdc21843256fb6c4e0d370a05f24a0bf213
launchpad.net/gocheck now at gustavo@niemeyer.net-20140225173054-xu9zlkf9kxhvow02
Building
Running tests from /home/tarmac/tmp/tmp.mz0bcXNGo4/src/launchpad.net/snappy
=== RUN Test
OK: 10 passed
--- PASS: Test (0.34 seconds)
PASS
coverage: 79.3% of statements
ok  	launchpad.net/snappy/clickdeb	0.346s	coverage: 79.3% of statements
=== RUN Test
OK: 6 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 12.7% of statements
ok  	launchpad.net/snappy/cmd/snappy	0.019s	coverage: 12.7% of statements
=== RUN Test
OK: 24 passed
--- PASS: Test (0.08 seconds)
PASS
coverage: 100.0% of statements
ok  	launchpad.net/snappy/coreconfig	0.087s	coverage: 100.0% of statements
=== RUN Test
OK: 33 passed
--- PASS: Test (1.69 seconds)
PASS
coverage: 74.0% of statements
ok  	launchpad.net/snappy/helpers	1.697s	coverage: 74.0% of statements
=== RUN Test
OK: 7 passed
--- PASS: Test (0.05 seconds)
PASS
coverage: 92.5% of statements
ok  	launchpad.net/snappy/logger	0.063s	coverage: 92.5% of statements
=== RUN Test
OK: 38 passed
--- PASS: Test (0.18 seconds)
PASS
coverage: 82.2% of statements
ok  	launchpad.net/snappy/partition	0.190s	coverage: 82.2% of statements
=== RUN Test
OK: 12 passed
--- PASS: Test (0.09 seconds)
PASS
coverage: 87.8% of statements
ok  	launchpad.net/snappy/policy	0.094s	coverage: 87.8% of statements
=== RUN Test
OK: 3 passed
--- PASS: Test (0.00 seconds)
PASS
coverage: 84.8% of statements
ok  	launchpad.net/snappy/priv	0.005s	coverage: 84.8% of statements
=== RUN Test
OK: 4 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 50.0% of statements
ok  	launchpad.net/snappy/progress	0.009s	coverage: 50.0% of statements
=== RUN Test
OK: 6 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 100.0% of statements
ok  	launchpad.net/snappy/release	0.010s	coverage: 100.0% of statements
=== RUN Test
2015-07-06 18:43:42 ERROR snappy logger.go:199 hello-app.potato failed to install: a package by that name is already installed
2015-07-06 18:43:42 ERROR snappy logger.go:199 foo failed to install: the given snap is already installed
foo foo-fork
2015/07/06 14:43:42 Use of deprecated "framework" key in yaml
2015/07/06 14:43:42 Use of deprecated "framework" key in yaml
2015/07/06 14:43:42 WARNING: Skipping hook apparmor
2015/07/06 14:43:42 WARNING: Skipping hook apparmor
2015/07/06 14:43:42 WARNING: Skipping hook apparmor
2015/07/06 14:43:47 WARNING: Skipping hook apparmor
2015/07/06 14:43:47 WARNING: Skipping hook apparmor
2015/07/06 14:43:47 WARNING: Skipping hook apparmor
2015/07/06 14:43:47 WARNING: Skipping hook apparmor
2015/07/06 14:43:47 WARNING: Skipping hook apparmor
2015-07-06 18:43:48 ERROR snappy logger.go:199 snappy package cannot be removed
2015-07-06 18:43:48 ERROR snappy logger.go:199 snappy package cannot be removed
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
2015/07/06 14:43:48 WARNING: Skipping hook apparmor
OK: 248 passed
--- PASS: Test (7.30 seconds)
PASS
coverage: 79.2% of statements
ok  	launchpad.net/snappy/snappy	7.313s	coverage: 79.2% of statements
=== RUN Test
OK: 12 passed
--- PASS: Test (0.52 seconds)
PASS
coverage: 79.3% of statements
ok  	launchpad.net/snappy/systemd	0.524s	coverage: 79.3% of statements
Running vet
Running lint
Lint complains:
cmd/snappy/cmd_internal_unpack.go:70:6: func readUid should be readUID helpers/touch.go:39:5: exported var ErrNotAbsPath should have comment or be unexported

# we always run in a fresh dir in tarmac
export GOPATH=$(mktemp -d)
trap 'rm -rf "$GOPATH"' EXIT

# this is a hack, but not sure tarmac is golang friendly
mkdir -p $GOPATH/src/launchpad.net/snappy
cp -a . $GOPATH/src/launchpad.net/snappy/
cd $GOPATH/src/launchpad.net/snappy

./run-checks

if which goctest >/dev/null; then
    goctest="goctest"
else
    goctest="go test"
fi

echo Checking formatting
fmt=$(gofmt -l .)

if [ -n "$fmt" ]; then
    echo "Formatting wrong in following files"
    echo $fmt
    exit 1
fi

echo Installing godeps
go get launchpad.net/godeps
export PATH=$PATH:$GOPATH/bin

echo Install golint
go get github.com/golang/lint/golint
export PATH=$PATH:$GOPATH/bin

echo Obtaining dependencies
godeps -u dependencies.tsv

# tests
echo Running tests from $(pwd)
$goctest -v -cover ./...

# go vet
echo Running vet
go vet ./...

# golint
echo Running lint
lint=$(golint ./...)
if [ -n "$lint" ]; then
    echo "Lint complains:"
    echo $lint
    exit 1
fi

« Back to merge proposal