Merge lp:~mterry/ubuntu-touch-session/socket into lp:ubuntu-touch-session

Proposed by Michael Terry
Status: Work in progress
Proposed branch: lp:~mterry/ubuntu-touch-session/socket
Merge into: lp:ubuntu-touch-session
Diff against target: 15 lines (+6/-0)
1 file modified
upstart-session/unity8.conf (+6/-0)
To merge this branch: bzr merge lp:~mterry/ubuntu-touch-session/socket
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+186391@code.launchpad.net

Commit message

Make sure to publish unity8's Mir socket for the benefit of any other apps that launch in the session.

Description of the change

Make sure to publish unity8's Mir socket for the benefit of any other apps that launch in the session.

Currently, Mir clients happen to find unity8 because they both hardcode /tmp/mir_socket as the fallback socket. But Mir is moving towards a more dynamic, potentially nested world. And we should actually determine and publicize the right socket in such cases.

To post a comment you must log in.
Revision history for this message
Loïc Minier (lool) wrote :

Ah this dates from when socket was in /tmp, and indeed we just moved it.

However we moved it to $XDG_RUNTIME_DIR/mir_socket as a file (not a dir with socket named after PID), so this branch conflicts with the upstream change now.

Revision history for this message
Michael Terry (mterry) wrote :

No it doesn't conflict, but it isn't necessary if Mir defaults to XDG_RUNTIME_DIR now (and likewise, the change in Mir would have been unnecessary if this had been merged). But I thought people were looking to revert the change in Mir for something less invasive?

This branch tells unity8 which socket to use, instead of relying on Mir's default.

Unmerged revisions

104. By Michael Terry

Make directory

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'upstart-session/unity8.conf'
2--- upstart-session/unity8.conf 2013-09-17 21:53:16 +0000
3+++ upstart-session/unity8.conf 2013-09-18 16:15:20 +0000
4@@ -13,5 +13,11 @@
5
6 script
7 sleep 2
8+
9+ # Point all future jobs in this session to our Mir socket
10+ mkdir -p $XDG_RUNTIME_DIR/mir_socket
11+ export MIR_SERVER_FILE=$XDG_RUNTIME_DIR/mir_socket/$$
12+ initctl set-env MIR_SOCKET=$MIR_SERVER_FILE
13+
14 exec unity8
15 end script

Subscribers

People subscribed via source and target branches