Merge lp:~mterry/quickly/648496 into lp:quickly

Proposed by Michael Terry
Status: Merged
Merge reported by: Michael Terry
Merged at revision: not available
Proposed branch: lp:~mterry/quickly/648496
Merge into: lp:quickly
Diff against target: 21 lines (+7/-1)
1 file modified
data/templates/ubuntu-application/create.py (+7/-1)
To merge this branch: bzr merge lp:~mterry/quickly/648496
Reviewer Review Type Date Requested Status
John C Barstow (community) Approve
Review via email: mp+36708@code.launchpad.net

Description of the change

See bug 648496. This just makes the relatively common (for first time users) NoWhoami exception less scary (and not trigger apport).

To post a comment you must log in.
Revision history for this message
John C Barstow (jbowtie) wrote :

This looks like an obvious improvement to me.

review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

I actually just proposed https://code.launchpad.net/~mterry/quickly/revert-bzr/+merge/36860 that reverts all the bzr changes. Meaning this branch should stick around, but wait until we put the bzr changes back in for natty cycle.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/templates/ubuntu-application/create.py'
2--- data/templates/ubuntu-application/create.py 2010-08-13 15:04:05 +0000
3+++ data/templates/ubuntu-application/create.py 2010-09-27 13:13:02 +0000
4@@ -108,10 +108,16 @@
5 # add it to revision control
6 print _("Creating bzr repository and commiting")
7 from bzrlib.bzrdir import BzrDir
8+from bzrlib.errors import NoWhoami
9 branch = BzrDir.create_branch_convenience(".")
10 wt = branch.bzrdir.open_workingtree()
11 wt.smart_add(["."])
12-wt.commit("Initial project creation with Quickly!")
13+try:
14+ wt.commit("Initial project creation with Quickly!")
15+except NoWhoami, err:
16+ # Don't show full traceback, just the user-friendly bits
17+ print err
18+ sys.exit(1)
19
20 # run the new application if X display
21 if templatetools.is_X_display() and os.path.isfile(exec_file):

Subscribers

People subscribed via source and target branches