Merge lp:~mterry/oxide/mirserver-1.5 into lp:oxide/1.5

Proposed by Michael Terry on 2015-04-10
Status: Rejected
Rejected by: Olivier Tilloy on 2015-10-06
Proposed branch: lp:~mterry/oxide/mirserver-1.5
Merge into: lp:oxide/1.5
Diff against target: 25 lines (+2/-2)
2 files modified
qt/core/browser/oxide_qt_browser_startup.cc (+1/-1)
qt/core/common/oxide_qt_screen_utils.cc (+1/-1)
To merge this branch: bzr merge lp:~mterry/oxide/mirserver-1.5
Reviewer Review Type Date Requested Status
Olivier Tilloy Disapprove on 2015-10-06
Chris Coulson 2015-04-10 Pending
Review via email: mp+255819@code.launchpad.net

This proposal supersedes a proposal from 2015-04-10.

Commit Message

Recognize "mirserver" as a valid ubuntu platform type, and use the GLES2 implementation in that case.

Description of the Change

Recognize "mirserver" as a valid ubuntu platform type, and use the GLES2 implementation in that case.

Same fix as https://code.launchpad.net/~mterry/oxide/mirserver/+merge/255128 but for 1.5

To post a comment you must log in.
Olivier Tilloy (osomon) wrote :

Not needed any longer, oxide 1.9 is now available on all supported releases of ubuntu.

review: Disapprove

Unmerged revisions

974. By Michael Terry on 2015-04-10

Support mirserver as a QPA platform, to fix a crash in the wizard

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qt/core/browser/oxide_qt_browser_startup.cc'
2--- qt/core/browser/oxide_qt_browser_startup.cc 2015-03-09 17:17:33 +0000
3+++ qt/core/browser/oxide_qt_browser_startup.cc 2015-04-10 12:47:44 +0000
4@@ -155,7 +155,7 @@
5 if (platform == QLatin1String("xcb")) {
6 supported_gl_impls |= oxide::SUPPORTED_GL_IMPL_DESKTOP_GL;
7 supported_gl_impls |= oxide::SUPPORTED_GL_IMPL_EGL_GLES2;
8- } else if (platform.startsWith("ubuntu")) {
9+ } else if (platform.startsWith("ubuntu") || platform == QLatin1String("mirserver")) {
10 supported_gl_impls |= oxide::SUPPORTED_GL_IMPL_EGL_GLES2;
11 } else {
12 LOG(WARNING) << "Unrecognized Qt platform: " << qPrintable(platform);
13
14=== modified file 'qt/core/common/oxide_qt_screen_utils.cc'
15--- qt/core/common/oxide_qt_screen_utils.cc 2015-01-24 15:38:34 +0000
16+++ qt/core/common/oxide_qt_screen_utils.cc 2015-04-10 12:47:44 +0000
17@@ -84,7 +84,7 @@
18 }
19
20 QString platform = QGuiApplication::platformName();
21- if (platform.startsWith("ubuntu")) {
22+ if (platform.startsWith("ubuntu") || platform == "mirserver") {
23 QByteArray grid_unit_px(qgetenv("GRID_UNIT_PX"));
24 bool ok;
25 float scale = grid_unit_px.toFloat(&ok);

Subscribers

People subscribed via source and target branches