Merge lp:~mterry/mir/fix-turkish into lp:mir

[Michael Terry]

Fix parsing environment arguments in the Turkish locale by calling tolower() with the standard C locale. (LP: #1398984)

In the Turkish locale, tolower('I') gives you back 'I'. This is often unexpected and a common 'gotcha' when comparing the results to a hardcoded string. One easy fix is to use the C locale for case conversions when you are only really interested in the normal ASCII set.

Fix parsing environment arguments in the Turkish locale by calling tolower() with the standard C locale.

In the Turkish locale, tolower('I') gives you back 'I'. This is often unexpected and a common 'gotcha' when comparing the results to a hardcoded string. One easy fix is to use the C locale for case conversions when you are only really interested in the normal ASCII set.

== Checklist ==

Did you test your feature/code change/bug fix ? what device(s) ?
- No, I tested locally that it gave the correct results in Turkish, but am waiting for jenkins to build debs for me to test on my device.

Did you break mir server API or ABI and have the relevant bumps to .so and debian docs been made ?
- NA

Did you break mir client API or ABI and have you followed up with the known clients & announced on mir-devel mailing list ?
- NA

[Kevin DuBois (kdub)]

okay by me, although I don't know anything about Turkish... Cemil? :)

review: Approve

[Cemil Azizoglu (cemil-azizoglu)]

(As the resident Turkish expert) Yeap, looks good.

review: Approve

[Alberto Aguirre (albaguirre)]

Wow...always amazed how locale issues manage to screw things up one way or another :)

review: Approve

[Daniel van Vugt (vanvugt)]

Sounds reasonable. This would also be an easy target for a regression test :)

review: Approve

=== modified file 'src/platform/options/program_option.cpp'
--- src/platform/options/program_option.cpp	2014-12-04 03:47:52 +0000
+++ src/platform/options/program_option.cpp	2014-12-04 19:18:32 +0000
@@ -22,6 +22,7 @@
 
 #include <fstream>
 #include <iostream>
+#include <locale>
 
 namespace mo = mir::options;
 namespace po = boost::program_options;
@@ -72,7 +73,7 @@
              for(auto& ch : result)
              {
                  if (ch == '_') ch = '-';
-                 else ch = tolower(ch);
+                 else ch = std::tolower(ch, std::locale::classic()); // avoid current locale
              }
 
              return result;