Merge lp:~mterry/libunity/enable-tests into lp:libunity

Proposed by Michael Terry
Status: Merged
Approved by: Michael Terry
Approved revision: 197
Merged at revision: 197
Proposed branch: lp:~mterry/libunity/enable-tests
Merge into: lp:libunity
Diff against target: 34 lines (+3/-3)
3 files modified
debian/changelog (+2/-1)
debian/control (+1/-0)
debian/rules (+0/-2)
To merge this branch: bzr merge lp:~mterry/libunity/enable-tests
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Didier Roche-Tolomelli Approve
Stephen M. Webb (community) Approve
Review via email: mp+133350@code.launchpad.net

Commit message

Enable tests during debian build

Description of the change

Enable tests for libunity at debian build time.

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

+1

review: Approve
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I'm getting this issue in my pbuilder:
/bin/bash: line 9: ./bug-1062331.py: Permission denied
FAIL: bug-1062331.py
/bin/bash: line 9: ./extras.py: Permission denied
FAIL: extras.py
===================
2 of 2 tests failed
===================
make[4]: *** [check-TESTS] Error 1

Can you give it a look? Do you have the same issue on your machine?

review: Needs Fixing
Revision history for this message
Michael Terry (mterry) wrote :

Didier, I don't see that when building in my pbuilder. Those files are both executable for me too. Do you see them as non-executable somehow?

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

figure out on IRC, needed a new version to not end up in diff.gz and having the executable bit stripped.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Jenkins failed due to job configuration error, re-approving after fixing the job.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Jenkins scripts were not handling a version number bump correctly. Applying a workaround and re-approving.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

grumble... pushed fix to the wrong location. trying again.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

Tried to reproduce test failure in an amd64 VM, but couldn't. So I'll try to approve again on the chance it was a fluke.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Martin Mrazik (mrazik) wrote :

I was seeing the same (random) fail/pass in bamf :-/ There seems to be something broken in the auto test.
See the last comment -- it passed on i386 but failed for amd64.

Revision history for this message
Michael Terry (mterry) wrote :

Saw another libunity branch land, so trying again.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~mterry/libunity/enable-tests updated
197. By Michael Terry

merge from trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-11-14 14:32:17 +0000
3+++ debian/changelog 2012-11-16 16:39:22 +0000
4@@ -1,6 +1,7 @@
5-libunity (6.10.0-0ubuntu2) UNRELEASED; urgency=low
6+libunity (6.11.0-0ubuntu1) UNRELEASED; urgency=low
7
8 [ Michael Terry ]
9+ * New upstream release
10 * debian/control:
11 - Update Vcs-Bzr
12 - Build-Depend on dh-autoreconf
13
14=== modified file 'debian/control'
15--- debian/control 2012-11-05 21:09:31 +0000
16+++ debian/control 2012-11-16 16:39:22 +0000
17@@ -17,6 +17,7 @@
18 libgirepository1.0-dev (>= 0.10),
19 libgtk-3-dev (>= 3.4.1),
20 python,
21+ python-gi,
22 gobject-introspection,
23 gir1.2-glib-2.0,
24 gir1.2-dbusmenu-glib-0.4 (>= 0.4.90),
25
26=== modified file 'debian/rules'
27--- debian/rules 2012-11-13 21:22:17 +0000
28+++ debian/rules 2012-11-16 16:39:22 +0000
29@@ -29,5 +29,3 @@
30 override_dh_makeshlibs:
31 dh_makeshlibs -plibunity-protocol-private0 -V
32 dh_makeshlibs --remaining-packages
33-
34-override_dh_auto_test:

Subscribers

People subscribed via source and target branches