Merge lp:~mterry/libunity-misc/modernize-build into lp:libunity-misc
Proposed by
Michael Terry
on 2012-12-12
| Status: | Merged |
|---|---|
| Approved by: | Didier Roche on 2012-12-13 |
| Approved revision: | 41 |
| Merged at revision: | 35 |
| Proposed branch: | lp:~mterry/libunity-misc/modernize-build |
| Merge into: | lp:libunity-misc |
| Diff against target: |
349 lines (+145/-104) 11 files modified
.bzr-builddeb/default.conf (+2/-0) debian/changelog (+9/-0) debian/compat (+1/-1) debian/control (+12/-9) debian/copyright (+100/-75) debian/libunity-misc-dev.install (+3/-3) debian/libunity-misc-doc.install (+1/-1) debian/libunity-misc4.install (+1/-1) debian/rules (+14/-13) debian/source/format (+1/-0) unity-misc.pc.in (+1/-1) |
| To merge this branch: | bzr merge lp:~mterry/libunity-misc/modernize-build |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Didier Roche | 2012-12-12 | Approve on 2012-12-13 | |
| PS Jenkins bot | continuous-integration | Pending | |
|
Review via email:
|
|||
Commit Message
Modernize build system by porting to dh9 and cleaning up packaging
Description of the Change
Modernize build system by porting to dh9. Plus some other cleanups around the place. Including adding gtk+-3.0 to the pc file.
To post a comment you must log in.
lp:~mterry/libunity-misc/modernize-build
updated
on 2012-12-12
- 39. By Michael Terry on 2012-12-12
-
fix copyright fields
- 40. By Michael Terry on 2012-12-12
-
add multiarch Pre-Depends and use gensymbols level 4
lp:~mterry/libunity-misc/modernize-build
updated
on 2012-12-12
- 41. By Michael Terry on 2012-12-12
-
bump version and add bzr-builddeb split mode config
| Michael Terry (mterry) wrote : | # |
Good catches! Added the bzr-builddeb and bumped the version. Please re-review!
| Didier Roche (didrocks) wrote : | # |
Looking very good to me :) Approving.
Thanks Michael! One less on the list.
review:
Approve

Hum, this looks mostly good but:
- you didn't bump the version, so bzr bd try to use the old tarball and can't rerun everything. Maybe you should bump to 4.0.5
- thre is no split mode and .bzr-buildddeb/ dir (forgotten bzr add? ;))