Merge lp:~mterry/libunity-misc/modernize-build into lp:libunity-misc

Proposed by Michael Terry on 2012-12-12
Status: Merged
Approved by: Didier Roche on 2012-12-13
Approved revision: 41
Merged at revision: 35
Proposed branch: lp:~mterry/libunity-misc/modernize-build
Merge into: lp:libunity-misc
Diff against target: 349 lines (+145/-104)
11 files modified
.bzr-builddeb/default.conf (+2/-0)
debian/changelog (+9/-0)
debian/compat (+1/-1)
debian/control (+12/-9)
debian/copyright (+100/-75)
debian/libunity-misc-dev.install (+3/-3)
debian/libunity-misc-doc.install (+1/-1)
debian/libunity-misc4.install (+1/-1)
debian/rules (+14/-13)
debian/source/format (+1/-0)
unity-misc.pc.in (+1/-1)
To merge this branch: bzr merge lp:~mterry/libunity-misc/modernize-build
Reviewer Review Type Date Requested Status
Didier Roche 2012-12-12 Approve on 2012-12-13
PS Jenkins bot continuous-integration Pending
Review via email: mp+139499@code.launchpad.net

Commit Message

Modernize build system by porting to dh9 and cleaning up packaging

Description of the Change

Modernize build system by porting to dh9. Plus some other cleanups around the place. Including adding gtk+-3.0 to the pc file.

To post a comment you must log in.
39. By Michael Terry on 2012-12-12

fix copyright fields

40. By Michael Terry on 2012-12-12

add multiarch Pre-Depends and use gensymbols level 4

Didier Roche (didrocks) wrote :

Hum, this looks mostly good but:
- you didn't bump the version, so bzr bd try to use the old tarball and can't rerun everything. Maybe you should bump to 4.0.5
- thre is no split mode and .bzr-buildddeb/ dir (forgotten bzr add? ;))

review: Needs Fixing
41. By Michael Terry on 2012-12-12

bump version and add bzr-builddeb split mode config

Michael Terry (mterry) wrote :

Good catches! Added the bzr-builddeb and bumped the version. Please re-review!

Didier Roche (didrocks) wrote :

Looking very good to me :) Approving.
Thanks Michael! One less on the list.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory '.bzr-builddeb'
2=== added file '.bzr-builddeb/default.conf'
3--- .bzr-builddeb/default.conf 1970-01-01 00:00:00 +0000
4+++ .bzr-builddeb/default.conf 2012-12-12 17:54:19 +0000
5@@ -0,0 +1,2 @@
6+[BUILDDEB]
7+split = True
8
9=== modified file 'debian/changelog'
10--- debian/changelog 2011-09-29 15:04:00 +0000
11+++ debian/changelog 2012-12-12 17:54:19 +0000
12@@ -1,3 +1,12 @@
13+libunity-misc (4.0.5-0ubuntu1) UNRELEASED; urgency=low
14+
15+ * Convert to dh9
16+ * Bump standards to 3.9.4
17+ * Update copyright to dep5 format
18+ * Automatic snapshot from revision 34 (bootstrap)
19+
20+ -- Michael Terry <mterry@ubuntu.com> Mon, 10 Dec 2012 17:09:27 -0500
21+
22 libunity-misc (4.0.4-0ubuntu2) oneiric; urgency=low
23
24 * Cherry-pick from upstream:
25
26=== modified file 'debian/compat'
27--- debian/compat 2010-01-25 16:04:10 +0000
28+++ debian/compat 2012-12-12 17:54:19 +0000
29@@ -1,1 +1,1 @@
30-5
31+9
32
33=== modified file 'debian/control'
34--- debian/control 2012-12-10 22:43:53 +0000
35+++ debian/control 2012-12-12 17:54:19 +0000
36@@ -1,26 +1,27 @@
37 Source: libunity-misc
38 Priority: optional
39 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
40-Build-Depends: debhelper (>= 5.0),
41- cdbs (>= 0.4.41),
42+Build-Depends: debhelper (>= 9),
43 dh-autoreconf,
44 gnome-common,
45 gtk-doc-tools,
46+ libglib2.0-dev (>= 2.22.0),
47 libgtk-3-dev (>= 3.0),
48- libglib2.0-dev (>= 2.22.0),
49 libx11-dev,
50-Standards-Version: 3.9.2
51+Standards-Version: 3.9.4
52 Section: libs
53 Homepage: https://launchpad.net/libunity-misc
54 # If you aren't a member of ~unity-team but need to upload packaging changes,
55 # just go ahead. ~unity-team will notice and sync up the code again.
56-Vcs-Bzr: https://code.launchpad.net/~unity-team/libunity/trunk
57+Vcs-Bzr: https://code.launchpad.net/~unity-team/libunity-misc/trunk
58
59 Package: libunity-misc-dev
60 Section: libdevel
61 Architecture: any
62-Depends: libunity-misc4 (= ${binary:Version}), ${misc:Depends},
63+Depends: ${misc:Depends},
64+ libunity-misc4 (= ${binary:Version}),
65 libglib2.0-dev (>= 2.22.0),
66+ libgtk-3-dev (>= 3.0),
67 Description: Miscellaneous functions for Unity - development files
68 libunity-misc is a shared library that provides miscellaneous functions for
69 Unity.
70@@ -30,7 +31,9 @@
71 Package: libunity-misc4
72 Section: libs
73 Architecture: any
74-Depends: ${shlibs:Depends}, ${misc:Depends}
75+Pre-Depends: ${misc:Pre-Depends}
76+Depends: ${misc:Depends},
77+ ${shlibs:Depends},
78 Description: Miscellaneous functions for Unity - shared library
79 libunity-misc is a shared library that provides miscellaneous functions for
80 Unity.
81@@ -40,8 +43,8 @@
82 Package: libunity-misc-doc
83 Architecture: all
84 Section: doc
85-Depends: ${misc:Depends}
86-Suggests: devhelp
87+Depends: ${misc:Depends},
88+Suggests: devhelp,
89 Description: Miscellaneous functions for Unity - documentation
90 libunity-misc is a shared library that provides miscellaneous functions for
91 Unity.
92
93=== modified file 'debian/copyright'
94--- debian/copyright 2010-06-03 17:19:27 +0000
95+++ debian/copyright 2012-12-12 17:54:19 +0000
96@@ -1,75 +1,100 @@
97-This work was packaged for Ubuntu by:
98-
99- Didier Roche <didrocks@ubuntu.com> on Fri, 15 Jan 2010 17:05:36 +0100
100-
101-It was downloaded from https://launchpad.net/libunity-misc
102-
103-Upstream Author(s):
104-
105- Neil Jagdish Patel <neil.patel@canonical.com>
106- Anders Carlsson <andersca@gnu.org>
107- Vincent Untz
108- Neil Jagdish Patel <neil.patel@canonical.com>
109-
110-Copyright:
111-
112- Copyright (C) 2002 Anders Carlsson
113- Copyright (C) 2003-2006 Vincent Untz
114- Copyright (C) 2008 Red Hat, Inc.
115- Copyright (C) 2009 Gnome Shell
116- Copyright (C) 2010 Canonical, Ltd.
117-
118-License:
119-
120- When not otherwise specified, the following license applies:
121-
122- This library is free software; you can redistribute it and/or
123- modify it under the terms of the GNU Lesser General Public
124- License Version as published by the Free Software Foundation; either
125- version 2 of the License, or (at your option) any later version.
126-
127- This library is distributed in the hope that it will be useful,
128- but WITHOUT ANY WARRANTY; without even the implied warranty of
129- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
130- Lesser General Public License for more details.
131-
132-On Debian systems, the complete text of the GNU Lesser General Public License
133-can be found in `/usr/share/common-licenses/LGPL-2'
134-
135- * unity-misc/unity-misc.h:
136-
137- This library is free software; you can redistribute it and/or modify
138- it under the terms of the GNU Lesser General Public License
139- version 3.0 as published by the Free Software Foundation.
140-
141- This library is distributed in the hope that it will be useful,
142- but WITHOUT ANY WARRANTY; without even the implied warranty of
143- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
144- GNU Lesser General Public License version 3.0 for more details.
145-
146-On Debian systems, the complete text of the GNU Lesser General Public License
147-can be found in `/usr/share/common-licenses/LGPL-3'
148-
149- * unity-misc/unity-tray-manager.h,shell-embedded-window-private.h,
150- unity-tray-manager.c,shell-embedded-window.c,shell-gtk-embed.h,
151- shell-gtk-embed.c,shell-embedded-window.h:
152-
153- This program is free software: you can redistribute it and/or modify it
154- under the terms of the the GNU General Public License version 2, as
155- published by the Free Software Foundation.
156-
157- This program is distributed in the hope that it will be useful, but
158- WITHOUT ANY WARRANTY; without even the implied warranties of
159- MERCHANTABILITY, SATISFACTORY QUALITY or FITNESS FOR A PARTICULAR
160- PURPOSE. See the applicable version of the GNU Lesser General Public
161- License for more details.
162-
163-On Debian systems, the complete text of the GNU General Public License
164-can be found in `/usr/share/common-licenses/GPL-2'
165-
166-
167-The Debian packaging is:
168-
169- Copyright (C) 2010 Canonical Ltd.
170-
171-and is licensed under the GPL version 3, see `/usr/share/common-licenses/GPL-3'.
172+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
173+Upstream-Name: libunity-misc
174+Source: http://launchpad.net/libunity-misc
175+
176+Files: *
177+Copyright: 2010-2012 Canonical, Ltd.
178+License: LGPL-2+
179+
180+Files: unity-misc/fixedtip.c
181+Copyright: 2001 Havoc Pennington
182+ 2003-2006 Vincent Untz
183+License: GPL-2+
184+
185+Files: unity-misc/fixedtip.h
186+Copyright: 2001 Havoc Pennington
187+ 2002 Red Hat Inc.
188+ 2003-2006 Vincent Untz
189+License: GPL-2+
190+
191+Files: unity-misc/gnome-bg-slideshow.c
192+Copyright: 2000 Eazel, Inc.
193+ 2007-2008 Red Hat, Inc.
194+ 2011 Canonical Ltd.
195+License: LGPL-2+
196+
197+Files: unity-misc/gnome-bg-slideshow.h
198+Copyright: 2007 Red Hat, Inc.
199+License: LGPL-2+
200+
201+Files: unity-misc/na-tray-manager.[ch]
202+ unity-misc/na-tray.h
203+Copyright: 2002 Anders Carlsson <andersca@gnu.org>
204+ 2003-2006 Vincent Untz
205+License: LGPL-2+
206+
207+Files: unity-misc/na-tray-child.[ch]
208+Copyright: 2002 Anders Carlsson <andersca@gnu.org>
209+ 2003-2006 Vincent Untz
210+ 2008 Red Hat, Inc.
211+License: LGPL-2+
212+
213+Files: unity-misc/na-tray.c
214+Copyright: 2002 Red Hat, Inc.
215+ 2003-2006 Vincent Untz
216+ 2007 Christian Persch
217+License: GPL-2+
218+
219+Files: debian/*
220+Copyright: 2010-2012 Canonical Ltd
221+License: GPL-3
222+
223+License: GPL-2+
224+ This program is free software: you can redistribute it and/or modify
225+ it under the terms of the GNU General Public License as published by
226+ the Free Software Foundation, either version 2 of the License, or
227+ (at your option) any later version.
228+ .
229+ This program is distributed in the hope that it will be useful,
230+ but WITHOUT ANY WARRANTY; without even the implied warranty of
231+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
232+ GNU General Public License for more details.
233+ .
234+ You should have received a copy of the GNU General Public License
235+ along with this program. If not, see <http://www.gnu.org/licenses/>.
236+ .
237+ On Debian systems, the complete text of the GNU General Public License
238+ can be found in `/usr/share/common-licenses/GPL-2'
239+
240+License: GPL-3
241+ This program is free software: you can redistribute it and/or modify
242+ it under the terms of the GNU General Public License as published by
243+ the Free Software Foundation, version 3 of the License.
244+ .
245+ This program is distributed in the hope that it will be useful,
246+ but WITHOUT ANY WARRANTY; without even the implied warranty of
247+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
248+ GNU General Public License for more details.
249+ .
250+ You should have received a copy of the GNU General Public License
251+ along with this program. If not, see <http://www.gnu.org/licenses/>.
252+ .
253+ On Debian systems, the complete text of the GNU General Public License
254+ can be found in `/usr/share/common-licenses/GPL-3'
255+
256+License: LGPL-2+
257+ This program is free software: you can redistribute it and/or modify
258+ it under the terms of the GNU Lesser General Public License as published by
259+ the Free Software Foundation, either version 2 of the License, or
260+ (at your option) any later version.
261+ .
262+ This program is distributed in the hope that it will be useful,
263+ but WITHOUT ANY WARRANTY; without even the implied warranty of
264+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
265+ GNU Lesser General Public License for more details.
266+ .
267+ You should have received a copy of the GNU Lesser General Public License
268+ along with this program. If not, see <http://www.gnu.org/licenses/>.
269+ .
270+ On Debian systems, the complete text of the GNU Lesser General Public License
271+ can be found in `/usr/share/common-licenses/LGPL-2'
272
273=== modified file 'debian/libunity-misc-dev.install'
274--- debian/libunity-misc-dev.install 2010-01-25 16:04:10 +0000
275+++ debian/libunity-misc-dev.install 2012-12-12 17:54:19 +0000
276@@ -1,3 +1,3 @@
277-debian/tmp/usr/include/*
278-debian/tmp/usr/lib/lib*.so
279-debian/tmp/usr/lib/pkgconfig/*
280+usr/include/*
281+usr/lib/*/lib*.so
282+usr/lib/*/pkgconfig/*
283
284=== modified file 'debian/libunity-misc-doc.install'
285--- debian/libunity-misc-doc.install 2010-01-28 20:59:38 +0000
286+++ debian/libunity-misc-doc.install 2012-12-12 17:54:19 +0000
287@@ -1,1 +1,1 @@
288-debian/tmp/usr/share/gtk-doc/
289+usr/share/gtk-doc/
290
291=== modified file 'debian/libunity-misc4.install'
292--- debian/libunity-misc4.install 2011-06-21 17:06:08 +0000
293+++ debian/libunity-misc4.install 2012-12-12 17:54:19 +0000
294@@ -1,1 +1,1 @@
295-debian/tmp/usr/lib/lib*.so.*
296+usr/lib/*/lib*.so.*
297
298=== modified file 'debian/rules'
299--- debian/rules 2012-12-10 22:43:53 +0000
300+++ debian/rules 2012-12-12 17:54:19 +0000
301@@ -1,17 +1,18 @@
302 #!/usr/bin/make -f
303
304-include /usr/share/cdbs/1/rules/debhelper.mk
305-include /usr/share/cdbs/1/class/autotools.mk
306-include /usr/share/cdbs/1/rules/simple-patchsys.mk
307-include /usr/share/cdbs/1/rules/utils.mk
308-include /usr/share/cdbs/1/rules/autoreconf.mk
309-
310-LDFLAGS += -Wl,-O1 -Wl,--as-needed
311-DEB_DH_AUTORECONF_ARGS = env NOCONFIGURE=1 ./autogen.sh
312-DEB_CONFIGURE_EXTRA_FLAGS = --enable-gtk-doc
313-
314-common-binary-post-install-arch::
315+export DEB_LDFLAGS_MAINT_APPEND = -Wl,-O1 -Wl,--as-needed
316+export DPKG_GENSYMBOLS_CHECK_LEVEL = 4
317+
318+%:
319+ dh $@ --with autoreconf
320+
321+override_dh_autoreconf:
322+ NOCONFIGURE=1 dh_autoreconf ./autogen.sh
323+
324+override_dh_auto_configure:
325+ dh_auto_configure -- --enable-gtk-doc
326+
327+override_dh_install:
328 find debian/tmp/usr/lib -name \*.la -exec rm {} \;
329 find debian/tmp/usr/lib -name \*.a -exec rm {} \;
330-
331-common-binary-predeb-arch:: list-missing
332+ dh_install --fail-missing
333
334=== added directory 'debian/source'
335=== added file 'debian/source/format'
336--- debian/source/format 1970-01-01 00:00:00 +0000
337+++ debian/source/format 2012-12-12 17:54:19 +0000
338@@ -0,0 +1,1 @@
339+1.0
340
341=== modified file 'unity-misc.pc.in'
342--- unity-misc.pc.in 2011-02-17 18:54:06 +0000
343+++ unity-misc.pc.in 2012-12-12 17:54:19 +0000
344@@ -8,4 +8,4 @@
345 Version: @VERSION@
346 Libs: -L${libdir} -lunity-misc
347 Cflags: -I${includedir}/unity-misc
348-Requires: glib-2.0 gthread-2.0 gobject-2.0 gio-2.0 gio-unix-2.0
349+Requires: glib-2.0 gthread-2.0 gobject-2.0 gio-2.0 gio-unix-2.0 gtk+-3.0

Subscribers

People subscribed via source and target branches

to all changes: