Merge lp:~mterry/launchpad-integration/ftbfs-and-override into lp:launchpad-integration

Proposed by Michael Terry
Status: Merged
Merged at revision: 158
Proposed branch: lp:~mterry/launchpad-integration/ftbfs-and-override
Merge into: lp:launchpad-integration
Diff against target: 90 lines (+24/-11)
4 files modified
debian/changelog (+14/-0)
debian/rules (+5/-9)
launchpad-integration.in (+1/-1)
launchpadintegration/packageinfo.py (+4/-1)
To merge this branch: bzr merge lp:~mterry/launchpad-integration/ftbfs-and-override
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+41002@code.launchpad.net

Description of the change

Fix FTBFS on non-i386 and merge Philip Peitsch's branch to allow overriding the status file location (something that quickly wants).

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-11-15 17:24:29 +0000
3+++ debian/changelog 2010-11-16 19:43:31 +0000
4@@ -1,3 +1,17 @@
5+launchpad-integration (0.1.43) natty; urgency=low
6+
7+ [ Michael Terry ]
8+ * debian/rules:
9+ - Fix FTBFS by installing the gtk3 library even on non-i386 builds
10+
11+ [ Philip Peitsch ]
12+ * launchpadintegration/packageinfo.py:
13+ - Allow overriding STATUSFILE by specifying LPI_PACKAGE_FILE env var
14+ * launchpad-integration.in:
15+ - Allow overriding PYTHONPATH for easier testing
16+
17+ -- Michael Terry <mterry@ubuntu.com> Tue, 16 Nov 2010 11:15:33 -0500
18+
19 launchpad-integration (0.1.42) natty; urgency=low
20
21 * debian/liblaunchpad-integration-dev.install: use the correct vapi directory
22
23=== modified file 'debian/rules'
24--- debian/rules 2010-11-09 22:59:13 +0000
25+++ debian/rules 2010-11-16 19:43:31 +0000
26@@ -75,14 +75,13 @@
27 touch stamp-build-pyversions
28 stamp-build-gtk3: stamp-configure-gtk3
29 : # build for GTK+ 3.0
30- set -e; \
31- $(MAKE) -C build-gtk3;
32+ $(MAKE) -C build-gtk3
33 touch stamp-build-gtk3
34
35 binary-predeb/gir%::
36 dh_girepository -p$(cdbs_curpkg)
37
38-binary-install/launchpad-integration:: stamp-build-pyversions stamp-build-gtk3
39+binary-install/launchpad-integration:: stamp-build-pyversions
40 ifneq (,$(strip $(OTHER_VERS)))
41 : # install for other python versions
42 set -e; \
43@@ -102,15 +101,12 @@
44 mv $$i $$(dirname $$i)/$${b}_d.so; \
45 done
46
47+ dh_pycentral -plaunchpad-integration
48+
49+common-install-prehook-arch:: stamp-build-gtk3
50 : # install for GTK+ 3.0
51- set -e; \
52 $(MAKE) -C build-gtk3 DESTDIR=$(CURDIR)/debian/tmp install
53
54- dh_pycentral -plaunchpad-integration
55-
56-binary-install/liblaunchpad-integration-3.0-1:: binary-install/launchpad-integration
57-binary-install/liblaunchpad-integration-3.0-dev:: binary-install/launchpad-integration
58-
59 binary-install/python-launchpad-integration:: binary-install/launchpad-integration
60 DH_PYCENTRAL=nomove dh_pycentral -ppython-launchpad-integration
61
62
63=== modified file 'launchpad-integration.in'
64--- launchpad-integration.in 2005-07-12 11:07:26 +0000
65+++ launchpad-integration.in 2010-11-16 19:43:31 +0000
66@@ -6,7 +6,7 @@
67
68 exec @PYTHON@ -c "
69 import sys
70-sys.path.insert(0, '${pkgdatadir}')
71+sys.path.append('${pkgdatadir}')
72 from launchpadintegration.main import main
73 sys.exit(main())
74 " ${1+"$@"}
75
76=== modified file 'launchpadintegration/packageinfo.py'
77--- launchpadintegration/packageinfo.py 2006-10-26 13:47:28 +0000
78+++ launchpadintegration/packageinfo.py 2010-11-16 19:43:31 +0000
79@@ -14,7 +14,10 @@
80
81 DPKGDIR = '/var/lib/dpkg'
82 INFODIR = os.path.join(DPKGDIR, 'info')
83-STATUSFILE = os.path.join(DPKGDIR, 'status')
84+STATUSFILE = os.environ.get('LPI_PACKAGE_FILE', os.path.join(DPKGDIR, 'status'))
85+
86+if os.environ.has_key('LPI_PACKAGE_FILE'):
87+ print "Using STATUSFILE: %s"%STATUSFILE
88
89 class PackageNotFoundError(Exception):
90 pass

Subscribers

People subscribed via source and target branches

to all changes: