Merge lp:~mterry/indicator-keyboard/snap-root into lp:indicator-keyboard
Proposed by
Michael Terry
Status: | Merged |
---|---|
Approved by: | dobey |
Approved revision: | 1107 |
Merged at revision: | 1165 |
Proposed branch: | lp:~mterry/indicator-keyboard/snap-root |
Merge into: | lp:indicator-keyboard |
Diff against target: |
9 lines (+1/-1) 1 file modified
data/indicator-keyboard.conf.in (+1/-1) |
To merge this branch: | bzr merge lp:~mterry/indicator-keyboard/snap-root |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
unity-api-1-bot | continuous-integration | Needs Fixing | |
dobey (community) | Approve | ||
Review via email: mp+308169@code.launchpad.net |
Commit message
Work inside a snap by prefixing hard coded paths with $SNAP.
Description of the change
There are also two hardcoded paths in the data/*.desktop.in files. But that's a static desktop file, so $SNAP isn't appropriate.
I'm not sure what the best solution for those is, but presumably it would lie in whichever component consumes the desktop file, not this package.
To post a comment you must log in.
FAILED: Continuous integration, rev:1107 /jenkins. canonical. com/unity- api-1/job/ lp-indicator- keyboard- ci/1/ /jenkins. canonical. com/unity- api-1/job/ build/1221/ console /jenkins. canonical. com/unity- api-1/job/ build-0- fetch/1228 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1012 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1012/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= zesty/1012/ console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1012 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1012/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= zesty/1012/ console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 1012 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 1012/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= zesty/1012/ console
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
Click here to trigger a rebuild: /jenkins. canonical. com/unity- api-1/job/ lp-indicator- keyboard- ci/1/rebuild
https:/