Merge lp:~mterry/indicator-datetime/snap-root into lp:indicator-datetime

Proposed by Michael Terry
Status: Merged
Approved by: Charles Kerr
Approved revision: 463
Merged at revision: 471
Proposed branch: lp:~mterry/indicator-datetime/snap-root
Merge into: lp:indicator-datetime
Diff against target: 9 lines (+1/-1)
1 file modified
data/indicator-datetime.conf.in (+1/-1)
To merge this branch: bzr merge lp:~mterry/indicator-datetime/snap-root
Reviewer Review Type Date Requested Status
Lukáš Tinkl (community) Needs Information
unity-api-1-bot continuous-integration Needs Fixing
Review via email: mp+308171@code.launchpad.net

Commit message

Run inside a snap by prefixing hard coded paths with $SNAP.

Description of the change

There are many other instances of hardcoded paths in the code. This is just a drive-by fixing of the upstart job to at least let it launch.

Other cases that I haven't tried to address here:

- There are also two hardcoded paths in the data/*.desktop.in files. But that's a static desktop file, so $SNAP isn't appropriate. I'm not sure what the best solution for those is, but presumably it would lie in whichever component consumes the desktop file, not this package.

- The com.ubuntu.touch.AccountsService.Sound.xml file has hardcoded paths to a couple sound files.

- ALARM_DEFAULT_SOUND and CALENDAR_DEFAULT_SOUND are replaced in many files. Some data (gschema) and some code. The code instances can easily be changed to prefix $SNAP. The data files would need a rethink.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

For some reason, this indicator stopped running for me in a u7 session with this change

review: Needs Information

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/indicator-datetime.conf.in'
2--- data/indicator-datetime.conf.in 2014-02-20 03:38:12 +0000
3+++ data/indicator-datetime.conf.in 2016-10-11 18:07:31 +0000
4@@ -6,4 +6,4 @@
5 respawn
6 respawn limit 2 10
7
8-exec @pkglibexecdir@/indicator-datetime-service
9+exec $SNAP@pkglibexecdir@/indicator-datetime-service

Subscribers

People subscribed via source and target branches