Merge lp:~mterry/indicator-datetime/iso8601 into lp:indicator-datetime/13.04

Proposed by Michael Terry
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 210
Merged at revision: 210
Proposed branch: lp:~mterry/indicator-datetime/iso8601
Merge into: lp:indicator-datetime/13.04
Diff against target: 15 lines (+4/-1)
1 file modified
src/datetime-prefs.c (+4/-1)
To merge this branch: bzr merge lp:~mterry/indicator-datetime/iso8601
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Mathieu Trudel-Lapierre Approve
Review via email: mp+151989@code.launchpad.net

Commit message

Go back to ISO 8601 dates for the date-picker widget. This way we know how to parse it again when the user manually edits the string.

Description of the change

This fixes issues with manually editing the date field in some locales (like Canada).

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/datetime-prefs.c'
2--- src/datetime-prefs.c 2012-10-09 17:20:35 +0000
3+++ src/datetime-prefs.c 2013-03-06 15:38:01 +0000
4@@ -498,7 +498,10 @@
5 }
6 }
7 else {
8- format = "%x";
9+ // This is intentionally not "%x". See https://launchpad.net/bugs/1149696
10+ // If you are willing to do the hard work of writing a locale-sensitive
11+ // date parser, there is an open bug: https://launchpad.net/bugs/729056
12+ format = "%Y-%m-%d";
13 }
14
15 GDateTime * datetime = g_date_time_new_from_unix_local (gtk_spin_button_get_value (GTK_SPIN_BUTTON (spinner)));

Subscribers

People subscribed via source and target branches