Merge lp:~mterry/indicator-appmenu/cleaner-remove into lp:indicator-appmenu/0.3
Proposed by
Michael Terry
Status: | Merged |
---|---|
Merged at revision: | 96 |
Proposed branch: | lp:~mterry/indicator-appmenu/cleaner-remove |
Merge into: | lp:indicator-appmenu/0.3 |
Diff against target: |
84 lines (+31/-27) 1 file modified
src/window-menus.c (+31/-27) |
To merge this branch: | bzr merge lp:~mterry/indicator-appmenu/cleaner-remove |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email: mp+48364@code.launchpad.net |
Description of the change
So when I was in the indicator-appmenu code, I noticed a TODO in the bit that removes entries from the window menu code. It currently just deleted the last entry in the list instead of the requested entry.
I haven't found code that hits this bug, so I'm not sure how important this is, but since I was there, I whipped up a little searcher function and used it there and elsewhere to grab an entry from the internal list.
Didn't seem to make things worse, though it also didn't make things noticeably better.
To post a comment you must log in.
Ah, I couldn't figure out why I hadn't done the search before with the entries' menu item pointer. Forgot that I added that recently :) Good fix!