Merge lp:~mterry/indicator-application/update-label-too into lp:indicator-application/0.4

Proposed by Michael Terry on 2011-02-11
Status: Merged
Merged at revision: 181
Proposed branch: lp:~mterry/indicator-application/update-label-too
Merge into: lp:indicator-application/0.4
Diff against target: 13 lines (+4/-0)
1 file modified
src/application-service-appstore.c (+4/-0)
To merge this branch: bzr merge lp:~mterry/indicator-application/update-label-too
Reviewer Review Type Date Requested Status
Ted Gould (community) 2011-02-11 Approve on 2011-02-16
Review via email: mp+49403@code.launchpad.net

Description of the change

In debugging bug 712581, I realized why the keyboard layout label was not being updated. It was because indicator-application was doing an apply_status right before processing the XAyatanaNewLabel signal. So when it processed the NewLabel signal, it thought it already had the new labels (set during apply_status) and ignored it.

This branch makes it so that when emitting an IconChanged signal as part of apply_status, it also emits a LabelChanged signal.

To post a comment you must log in.
Ted Gould (ted) :
review: Approve
Ted Gould (ted) wrote :

  review approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/application-service-appstore.c'
2--- src/application-service-appstore.c 2011-02-07 18:01:11 +0000
3+++ src/application-service-appstore.c 2011-02-11 15:11:39 +0000
4@@ -845,6 +845,10 @@
5
6 emit_signal (appstore, "ApplicationIconChanged",
7 g_variant_new ("(is)", position, newicon));
8+ emit_signal (appstore, "ApplicationLabelChanged",
9+ g_variant_new ("(iss)", position,
10+ app->label != NULL ? app->label : "",
11+ app->guide != NULL ? app->guide : ""));
12 }
13 }
14

Subscribers

People subscribed via source and target branches