Merge lp:~mterry/gsettings-ubuntu-touch-schemas/lax-greeter-perms into lp:gsettings-ubuntu-touch-schemas
| Status: | Merged |
|---|---|
| Approved by: | Sebastien Bacher |
| Approved revision: | 30 |
| Merged at revision: | 30 |
| Proposed branch: | lp:~mterry/gsettings-ubuntu-touch-schemas/lax-greeter-perms |
| Merge into: | lp:gsettings-ubuntu-touch-schemas |
| Diff against target: |
12 lines (+1/-1) 1 file modified
accountsservice/50-com.ubuntu.AccountsService.pkla (+1/-1) |
| To merge this branch: | bzr merge lp:~mterry/gsettings-ubuntu-touch-schemas/lax-greeter-perms |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sebastien Bacher (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Allow the greeter to set AccountsService fields even when it is an inactive session (to reduce races between setting volume and logging in)
Description of the change
Allow the greeter to set AccountsService fields even when it is an inactive session (to reduce races between setting volume and logging in).
In testing the split greeter silo, it was noticed that occasionally volume wouldn't be synced correctly.
It seems that this is because (A) indicator-sound does some buffering when syncing changes to keep updates to 1-a-second (B) the user can swipe into the session before the updates hit dbus.
When that happens, the dbus call hits AccountsService after the greeter session is marked inactive by logind. So it is denied and the user session never sees the update.
Allowing the greeter to set fields while inactive doesn't seem like a problem. I don't think it can get up to mischief.
| PS Jenkins bot (ps-jenkins) wrote | # |
PASSED: Continuous integration, rev:30
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://