Merge lp:~mterry/gsettings-ubuntu-touch-schemas/input-schema into lp:gsettings-ubuntu-touch-schemas

Proposed by Michael Terry
Status: Merged
Approved by: Ken VanDine
Approved revision: 60
Merged at revision: 59
Proposed branch: lp:~mterry/gsettings-ubuntu-touch-schemas/input-schema
Merge into: lp:gsettings-ubuntu-touch-schemas
Diff against target: 96 lines (+73/-0)
3 files modified
accountsservice/Makefile.am (+1/-0)
accountsservice/com.ubuntu.AccountsService.Input.xml (+66/-0)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp:~mterry/gsettings-ubuntu-touch-schemas/input-schema
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Michael Zanetti (community) Approve
Review via email: mp+283546@code.launchpad.net

Commit message

Add com.ubuntu.AccountsService.Input schema.

Description of the change

This list of properties came from Ken (https://code.launchpad.net/~ken-vandine/unity8/mouse_touchpad_schema/+merge/281643).

= AccountsService =

But I've moved them to this more central location. And I've switched them to be AS properties.

I figured AS made more sense than gsettings because consider the encrypted-home case on the phone: a single user system, but now before the first login after booting, we change the user's mouse speed on them, and enable the touchpad while typing when they had it disabled. The user would be confused why we're losing settings.

Even in a multi-user case, some of these properties would want to be honored per-selected-user. Like maybe TouchpadDisableWhileTyping.

AS is a good place to keep these properties, so that the greeter can grab them if needed.

= Cursor Speed =

I've also updated the default for CursorSpeed to 0.75 from 0.5. It felt better to me (and we had complaints about 0.5 -- bug 1536383).

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

ack!

review: Approve
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'accountsservice/Makefile.am'
2--- accountsservice/Makefile.am 2014-07-08 13:39:18 +0000
3+++ accountsservice/Makefile.am 2016-01-21 21:06:33 +0000
4@@ -5,6 +5,7 @@
5 dist_policy_DATA = com.ubuntu.AccountsService.policy
6
7 accountsservice_schemas = \
8+ com.ubuntu.AccountsService.Input.xml \
9 com.ubuntu.AccountsService.SecurityPrivacy.xml \
10 com.ubuntu.AccountsService.Sound.xml \
11 com.ubuntu.touch.AccountsService.SecurityPrivacy.xml \
12
13=== added file 'accountsservice/com.ubuntu.AccountsService.Input.xml'
14--- accountsservice/com.ubuntu.AccountsService.Input.xml 1970-01-01 00:00:00 +0000
15+++ accountsservice/com.ubuntu.AccountsService.Input.xml 2016-01-21 21:06:33 +0000
16@@ -0,0 +1,66 @@
17+<node>
18+ <interface name="com.ubuntu.AccountsService.Input">
19+
20+ <annotation name="org.freedesktop.Accounts.VendorExtension" value="true"/>
21+
22+ <annotation name="org.freedesktop.Accounts.Authentication.ReadAny"
23+ value="com.ubuntu.AccountsService.GreeterReadAny"/>
24+
25+ <!-- "left" or "right" -->
26+ <property name="MousePrimaryButton" type="s" access="readwrite">
27+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="left"/>
28+ </property>
29+
30+ <!-- 0 to 1 -->
31+ <property name="MouseCursorSpeed" type="d" access="readwrite">
32+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="0.75"/>
33+ </property>
34+
35+ <!-- 0 to 1 -->
36+ <property name="MouseScrollSpeed" type="d" access="readwrite">
37+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="0.5"/>
38+ </property>
39+
40+ <!-- in milliseconds -->
41+ <property name="MouseDoubleClickSpeed" type="i" access="readwrite">
42+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="100"/>
43+ </property>
44+
45+ <!-- "left" or "right" -->
46+ <property name="TouchpadPrimaryButton" type="s" access="readwrite">
47+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="left"/>
48+ </property>
49+
50+ <!-- 0 to 1 -->
51+ <property name="TouchpadCursorSpeed" type="d" access="readwrite">
52+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="0.75"/>
53+ </property>
54+
55+ <!-- 0 to 1 -->
56+ <property name="TouchpadScrollSpeed" type="d" access="readwrite">
57+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="0.5"/>
58+ </property>
59+
60+ <!-- in milliseconds -->
61+ <property name="TouchpadDoubleClickSpeed" type="i" access="readwrite">
62+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="100"/>
63+ </property>
64+
65+ <property name="TouchpadDisableWhileTyping" type="b" access="readwrite">
66+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="false"/>
67+ </property>
68+
69+ <property name="TouchpadTapToClick" type="b" access="readwrite">
70+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="false"/>
71+ </property>
72+
73+ <property name="TouchpadTwoFingerScroll" type="b" access="readwrite">
74+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="false"/>
75+ </property>
76+
77+ <property name="TouchpadDisableWithMouse" type="b" access="readwrite">
78+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
79+ </property>
80+
81+ </interface>
82+</node>
83
84=== modified file 'debian/changelog'
85--- debian/changelog 2015-06-08 15:25:08 +0000
86+++ debian/changelog 2016-01-21 21:06:33 +0000
87@@ -1,3 +1,9 @@
88+gsettings-ubuntu-touch-schemas (0.0.5) UNRELEASED; urgency=medium
89+
90+ * Add com.ubuntu.AccountsService.Input schema
91+
92+ -- Michael Terry <mterry@ubuntu.com> Thu, 21 Jan 2016 10:44:26 -0600
93+
94 gsettings-ubuntu-touch-schemas (0.0.4+15.10.20150608-0ubuntu1) wily; urgency=medium
95
96 [ Tiago Salem Herrmann ]

Subscribers

People subscribed via source and target branches