Merge lp:~mterry/gsettings-ubuntu-touch-schemas/greeter-messages into lp:gsettings-ubuntu-touch-schemas

Proposed by Michael Terry on 2015-02-06
Status: Work in progress
Proposed branch: lp:~mterry/gsettings-ubuntu-touch-schemas/greeter-messages
Merge into: lp:gsettings-ubuntu-touch-schemas
Diff against target: 12 lines (+1/-1)
1 file modified
accountsservice/com.ubuntu.touch.AccountsService.SecurityPrivacy.xml (+1/-1)
To merge this branch: bzr merge lp:~mterry/gsettings-ubuntu-touch-schemas/greeter-messages
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) 2015-02-06 Approve on 2015-02-06
Review via email: mp+248928@code.launchpad.net

Commit message

Per design discussions, the currently-unused MessagesWelcomeScreen property should default to false.

Description of the change

Per design discussions, the currently-unused MessagesWelcomeScreen property should default to false.

You can see the discussion in bug 1358340 (note comments #26 and #30). I plan to start using this property soon, but figured I'd start this change now, since it doesn't have to land in sync.

To post a comment you must log in.
Sebastien Bacher (seb128) wrote :

Thanks, feel free to land the change (or give me a ping if you want me to do it)

review: Approve
Michael Terry (mterry) wrote :

Setting this back to WIP. After further analysis, I think the discussion in that bug is incomplete. I want to wait until we see what Design comes up with for the final panel before committing to using this property.

Unmerged revisions

52. By Michael Terry on 2015-02-05

Default MessagesWelcomeScreen to false

51. By CI Train Bot Account on 2015-01-30

Releasing 0.0.3+15.04.20150130-0ubuntu1

50. By Tiago Salem Herrmann on 2015-01-30

Add MMS group chat option. Fixes: #1415458
Approved by: Sebastien Bacher, PS Jenkins bot

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'accountsservice/com.ubuntu.touch.AccountsService.SecurityPrivacy.xml'
2--- accountsservice/com.ubuntu.touch.AccountsService.SecurityPrivacy.xml 2014-03-04 20:05:11 +0000
3+++ accountsservice/com.ubuntu.touch.AccountsService.SecurityPrivacy.xml 2015-02-06 15:52:28 +0000
4@@ -8,7 +8,7 @@
5 </property>
6
7 <property name="MessagesWelcomeScreen" type="b" access="readwrite">
8- <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
9+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="false"/>
10 </property>
11
12 </interface>

Subscribers

People subscribed via source and target branches