Duplicity

Merge lp:~mterry/duplicity/pydrive-root into lp:~duplicity-team/duplicity/0.8-series

  1. pydrive-root
  2. Merge into 0.8-series
Proposed by Michael Terry
Status: Merged
Merged at revision: 1350
Proposed branch: lp:~mterry/duplicity/pydrive-root
Merge into: lp:~duplicity-team/duplicity/0.8-series
Diff against target: 11 lines (+1/-0)
1 file modified
duplicity/backends/pydrivebackend.py (+1/-0)
To merge this branch: bzr merge lp:~mterry/duplicity/pydrive-root
Reviewer Review Type Date Requested Status
duplicity-team Pending
Review via email: mp+363587@code.launchpad.net

Description of the change

Just a tiny fix to clean up the temporary file we create to find the root ID. It's a little surprising for the user if they wind up with this file called "i_am_in_root" that they don't know where it came from. Almost sounds like they were hacked.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'duplicity/backends/pydrivebackend.py'
2--- duplicity/backends/pydrivebackend.py 2018-11-29 19:00:15 +0000
3+++ duplicity/backends/pydrivebackend.py 2019-02-24 15:13:04 +0000
4@@ -94,6 +94,7 @@
5 file_in_root = self.drive.CreateFile({u'title': u'i_am_in_root'})
6 file_in_root.Upload()
7 parent_folder_id = file_in_root[u'parents'][0][u'id']
8+ file_in_root.Delete()
9
10 # Fetch destination folder entry and create hierarchy if required.
11 folder_names = string.split(parsed_url.path, u'/')

Subscribers

People subscribed via source and target branches