Merge lp:~mterry/duplicity/pydrive-root-0.7 into lp:duplicity/0.7-series

Proposed by Michael Terry on 2019-02-24
Status: Merged
Merged at revision: 1372
Proposed branch: lp:~mterry/duplicity/pydrive-root-0.7
Merge into: lp:duplicity/0.7-series
Diff against target: 11 lines (+1/-0)
1 file modified
duplicity/backends/pydrivebackend.py (+1/-0)
To merge this branch: bzr merge lp:~mterry/duplicity/pydrive-root-0.7
Reviewer Review Type Date Requested Status
duplicity-team 2019-02-24 Pending
Review via email: mp+363588@code.launchpad.net

Description of the change

Just a tiny fix to clean up the temporary file we create to find the root ID. It's a little surprising for the user if they wind up with this file called "i_am_in_root" that they don't know where it came from. Almost sounds like they were hacked.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'duplicity/backends/pydrivebackend.py'
2--- duplicity/backends/pydrivebackend.py 2017-11-01 12:41:49 +0000
3+++ duplicity/backends/pydrivebackend.py 2019-02-24 15:13:08 +0000
4@@ -92,6 +92,7 @@
5 file_in_root = self.drive.CreateFile({'title': 'i_am_in_root'})
6 file_in_root.Upload()
7 parent_folder_id = file_in_root['parents'][0]['id']
8+ file_in_root.Delete()
9
10 # Fetch destination folder entry and create hierarchy if required.
11 folder_names = string.split(parsed_url.path, '/')

Subscribers

People subscribed via source and target branches