Merge lp:~mterry/duplicity/look-at-partials-during-sync into lp:duplicity/0.6
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 761 | ||||
Proposed branch: | lp:~mterry/duplicity/look-at-partials-during-sync | ||||
Merge into: | lp:duplicity/0.6 | ||||
Diff against target: |
129 lines (+29/-18) 1 file modified
duplicity-bin (+29/-18) |
||||
To merge this branch: | bzr merge lp:~mterry/duplicity/look-at-partials-during-sync | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
duplicity-team | Pending | ||
Review via email: mp+67375@code.launchpad.net |
Description of the change
To fix bug 703142, we need to pay attention to local partial metadata files (see comment 8 in that bug).
This patch makes sure (A) that when we have a local-partial, we don't copy remote->local-final and (B) that we delete a local-final if we have a local-partial already.
It's fine to not have a local-final in these situations because clearly we got interrupted during the signature writing. Which means we still have a partial manifest hanging around, we will resume the backup, and the last volume will be re-uploaded. Thus, the signature and manifest will get re-uploaded anyway. So any remote or local-final signature at the start of the run is forgettable.
This patch also ensures that we run sync_archives() during a collection-status. But it makes sure to avoid a regression of bug 777377 by adding an argument that allows decryption or not. Without running sync_archives during a collection-status, we'd still hit bug 703142 during that operation.