Merge lp:~mterry/duplicity/ignore-missing into lp:duplicity/0.6

Proposed by Michael Terry
Status: Merged
Merged at revision: 928
Proposed branch: lp:~mterry/duplicity/ignore-missing
Merge into: lp:duplicity/0.6
Diff against target: 17 lines (+4/-5)
1 file modified
duplicity/util.py (+4/-5)
To merge this branch: bzr merge lp:~mterry/duplicity/ignore-missing
Reviewer Review Type Date Requested Status
duplicity-team Pending
Review via email: mp+185273@code.launchpad.net

Description of the change

Fix util.ignore_missing to actually work.

Spotted by Matthias Witte in bug 1216921, ignore_missing() does not actually work. I confirmed the problem and the fix he wrote.

To post a comment you must log in.
lp:~mterry/duplicity/ignore-missing updated
928. By Michael Terry

Fix else: to be except Exception:

929. By Michael Terry

Or better yet, just drop the stanza, it shouldn't be needed

Revision history for this message
Michael Terry (mterry) wrote :

Looks like you landed part of this, but not all of it. You need my further fixes to the patch to fix the test failures.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'duplicity/util.py'
2--- duplicity/util.py 2012-01-20 21:50:01 +0000
3+++ duplicity/util.py 2013-09-12 15:11:23 +0000
4@@ -114,9 +114,8 @@
5 """
6 try:
7 fn(filename)
8- except Exception:
9- type, value, tb = sys.exc_info() #@UnusedVariable
10- if isinstance(type, OSError) and value[0] == errno.ENOENT:
11+ except OSError, ex:
12+ if ex.errno == errno.ENOENT:
13 pass
14- raise
15-
16+ else:
17+ raise

Subscribers

People subscribed via source and target branches

to all changes: