Merge lp:~mterry/duplicity/delete-new-sig-in-cache into lp:duplicity/0.6

Proposed by Michael Terry
Status: Merged
Merged at revision: 892
Proposed branch: lp:~mterry/duplicity/delete-new-sig-in-cache
Merge into: lp:duplicity/0.6
Diff against target: 17 lines (+1/-6)
1 file modified
duplicity/collections.py (+1/-6)
To merge this branch: bzr merge lp:~mterry/duplicity/delete-new-sig-in-cache
Reviewer Review Type Date Requested Status
duplicity-team Pending
Review via email: mp+132790@code.launchpad.net

Description of the change

In duplicity 0.6.20, we fixed bug 1031269. This means that we no longer leave sig files on the remote location.

Leaving sig files on the remote location also caused a bug with deleting cache files. Code used to leave remote new-sig but delete the locale cache new-sig; this meant that we would keep downloadoing the new-sig all the time from remote. We had worked around that by just not deleting the new-sig in the cache, which was sort of the wrong side of that problem to tackle.

Now that we handle the remote new-sigs better (by deleting them), I don't think we need this code anymore. Patch by <email address hidden>.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'duplicity/collections.py'
2--- duplicity/collections.py 2012-09-19 17:29:46 +0000
3+++ duplicity/collections.py 2012-11-03 21:47:18 +0000
4@@ -151,12 +151,7 @@
5 if (pr
6 and pr.time == self.time
7 and pr.start_time == self.start_time
8- and pr.end_time == self.end_time
9- and pr.type != "new-sig" ):
10- # do not remove new sigs from the cache:
11- # they aren't removed from the remote archive,
12- # and subsequent backups will have to resync
13- # which is bad if running non-interactive with encrypt-key
14+ and pr.end_time == self.end_time):
15 try:
16 globals.archive_dir.append(lfn).delete()
17 except Exception:

Subscribers

People subscribed via source and target branches

to all changes: