Merge lp:~mterry/duplicity/always-delay into lp:duplicity/0.6

Proposed by Michael Terry
Status: Merged
Merged at revision: 825
Proposed branch: lp:~mterry/duplicity/always-delay
Merge into: lp:duplicity/0.6
Diff against target: 14 lines (+3/-1)
1 file modified
duplicity/backend.py (+3/-1)
To merge this branch: bzr merge lp:~mterry/duplicity/always-delay
Reviewer Review Type Date Requested Status
duplicity-team Pending
Review via email: mp+87909@code.launchpad.net

Description of the change

I've noticed some occasional odd SSL errors with the U1 backend that seemed transient, but with the current retry logic, we just hammer the server 5 times in a row instantly upon an error. It made me think that all errors, it doesn't hurt to give a server some breathing room on the order of 10s. It's not going to slow down operation much (since errors are the exception not the rule) and on odd server goofs, we buy ourselves some robustness.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'duplicity/backend.py'
2--- duplicity/backend.py 2011-10-08 15:55:26 +0000
3+++ duplicity/backend.py 2012-01-09 09:14:24 +0000
4@@ -313,7 +313,9 @@
5 log.Debug("Backtrace of previous error: %s"
6 % exception_traceback())
7 if isinstance(e, TemporaryLoadException):
8- time.sleep(30) # wait a bit before trying again
9+ time.sleep(30) # wait longer before trying again
10+ else:
11+ time.sleep(10) # wait a bit before trying again
12 # Now try one last time, but fatal-log instead of raising errors
13 kwargs = {"raise_errors" : False}
14 return fn(*args, **kwargs)

Subscribers

People subscribed via source and target branches

to all changes: