Merge lp:~mterry/deja-dup/quit-on-dbus-exit into lp:deja-dup/24
Proposed by
Michael Terry
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 1381 | ||||||||
Proposed branch: | lp:~mterry/deja-dup/quit-on-dbus-exit | ||||||||
Merge into: | lp:deja-dup/24 | ||||||||
Diff against target: |
67 lines (+30/-19) 1 file modified
monitor/monitor.vala (+30/-19) |
||||||||
To merge this branch: | bzr merge lp:~mterry/deja-dup/quit-on-dbus-exit | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Bruce Park (community) | Approve | ||
Review via email: mp+124606@code.launchpad.net |
Description of the change
Have deja-dup-monitor try to own a bus name on startup and quit if it can't own it or loses the name for any reason.
This fixes two issues:
1) A user somehow tries to run two monitors in the same session. This is almost always due to the user doing something goofy, but whatever, we should help the user there. (Bug 891797)
2) Quantal seems to have a new bug where logging out does not make old deja-dup-monitor processes quit. By owning a bus name, it makes it easy to notice when a dbus session dies, so that we can exit with the session. (Bug 1051811)
To post a comment you must log in.
Code looks good, test suite passes, and I confirmed interactively that I was unable to launch two instances of deja-dup-monitor from the source tree (second instance exits immediately).