dee

Merge lp:~mterry/dee/modern-build into lp:dee

Proposed by Michael Terry
Status: Merged
Approved by: Francis Ginther
Approved revision: 381
Merged at revision: 380
Proposed branch: lp:~mterry/dee/modern-build
Merge into: lp:dee
Diff against target: 104 lines (+16/-10)
7 files modified
debian/changelog (+2/-0)
debian/compat (+1/-1)
debian/control (+4/-1)
debian/gir1.2-dee-1.0.install (+1/-1)
debian/libdee-1.0-4.install (+1/-1)
debian/libdee-dev.install (+2/-2)
debian/rules (+5/-4)
To merge this branch: bzr merge lp:~mterry/dee/modern-build
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Didier Roche-Tolomelli Approve
Review via email: mp+133344@code.launchpad.net

Commit message

Switch debian/ to debhelper 9

Description of the change

Here's a branch to modernize debian/:

* Switch to dh9
  * Use multiarch
* Enable tests
* Use upstream ./autogen.sh instead of autoreconf

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

oupsss, my bad for compat not being bumped before (feels ashamed)

All looks good both source-wise and in my pbuilder. Approving. (Even the Pre-depends is there for the new multiarch support! ;)).

There is just a small warning I want to fix, this is coming in a new MP.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Build failed due to jenkins job config error. Fixed and re-approving.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-11-05 20:42:44 +0000
3+++ debian/changelog 2012-11-07 20:51:22 +0000
4@@ -2,6 +2,8 @@
5
6 * debian/control:
7 - Update Vcs-Bzr
8+ * debian/rules:
9+ - Update to dh9 and enable tests
10
11 -- Michael Terry <mterry@ubuntu.com> Mon, 05 Nov 2012 15:28:38 -0500
12
13
14=== modified file 'debian/compat'
15--- debian/compat 2010-05-25 15:16:55 +0000
16+++ debian/compat 2012-11-07 20:51:22 +0000
17@@ -1,1 +1,1 @@
18-5
19+9
20
21=== modified file 'debian/control'
22--- debian/control 2012-11-05 20:42:44 +0000
23+++ debian/control 2012-11-07 20:51:22 +0000
24@@ -2,10 +2,12 @@
25 Priority: optional
26 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
27 XSBC-Original-Maintainer: Kartik Mistry <kartik@debian.org>
28-Build-Depends: debhelper (>= 7.0.50),
29+Build-Depends: dbus-test-runner,
30+ debhelper (>= 9),
31 dh-autoreconf,
32 gir1.2-freedesktop,
33 gir1.2-glib-2.0,
34+ gnome-common,
35 gobject-introspection (>= 0.10.2),
36 gtk-doc-tools,
37 libglib2.0-dev (>= 2.26.0),
38@@ -25,6 +27,7 @@
39
40 Package: libdee-1.0-4
41 Architecture: any
42+Pre-Depends: ${misc:Pre-Depends}
43 Depends: ${shlibs:Depends}, ${misc:Depends}
44 Description: model to synchronize mutiple instances over DBus - shared lib
45 libdee is a shared library that provides objects that help
46
47=== modified file 'debian/gir1.2-dee-1.0.install'
48--- debian/gir1.2-dee-1.0.install 2011-12-07 11:35:57 +0000
49+++ debian/gir1.2-dee-1.0.install 2012-11-07 20:51:22 +0000
50@@ -1,2 +1,2 @@
51-debian/tmp/usr/lib/girepository-1.0/
52+debian/tmp/usr/lib/*/girepository-1.0/
53 debian/tmp/usr/lib/python*/dist-packages/gi/overrides/*.py
54
55=== modified file 'debian/libdee-1.0-4.install'
56--- debian/libdee-1.0-4.install 2011-12-07 11:35:57 +0000
57+++ debian/libdee-1.0-4.install 2012-11-07 20:51:22 +0000
58@@ -1,1 +1,1 @@
59-debian/tmp/usr/lib/lib*.so.*
60+debian/tmp/usr/lib/*/lib*.so.*
61
62=== modified file 'debian/libdee-dev.install'
63--- debian/libdee-dev.install 2010-11-25 14:26:28 +0000
64+++ debian/libdee-dev.install 2012-11-07 20:51:22 +0000
65@@ -1,5 +1,5 @@
66 debian/tmp/usr/include/*
67-debian/tmp/usr/lib/lib*.so
68-debian/tmp/usr/lib/pkgconfig/*
69+debian/tmp/usr/lib/*/lib*.so
70+debian/tmp/usr/lib/*/pkgconfig/*
71 debian/tmp/usr/share/vala/vapi/*
72 debian/tmp/usr/share/gir-1.0/*
73
74=== modified file 'debian/rules'
75--- debian/rules 2012-07-04 14:14:53 +0000
76+++ debian/rules 2012-11-07 20:51:22 +0000
77@@ -5,7 +5,10 @@
78 #export DH_VERBOSE=1
79
80 %:
81- dh --with python2 --with autoreconf $@
82+ dh $@ --with python2,autoreconf
83+
84+override_dh_autoreconf:
85+ NOCONFIGURE=1 dh_autoreconf ./autogen.sh
86
87 override_dh_auto_configure:
88 dh_auto_configure -- --enable-gtk-doc
89@@ -14,7 +17,7 @@
90 # install the python3 gir override file as well
91 PYTHON=python3 ./configure --prefix=/usr
92 cd bindings/python/ && DESTDIR=../../debian/tmp make install && cd ../..
93- rm debian/tmp/usr/lib/*.la
94+ rm debian/tmp/usr/lib/*/*.la
95 rm debian/tmp/usr/lib/python*/dist-packages/gi/overrides/*.pyc
96 rm debian/tmp/usr/lib/python*/dist-packages/gi/overrides/*.pyo
97 dh_install --fail-missing
98@@ -27,6 +30,4 @@
99 override_dh_strip:
100 dh_strip --dbg-package=libdee-1.0-4-dbg
101
102-override_dh_auto_test:
103-
104 .PHONY: override_dh_strip

Subscribers

People subscribed via source and target branches

to all changes: