Merge lp:~mterry/bamf/no-show-indicators into lp:bamf/0.4

Proposed by Michael Terry on 2010-12-09
Status: Rejected
Rejected by: Michal Hruby on 2012-01-12
Proposed branch: lp:~mterry/bamf/no-show-indicators
Merge into: lp:bamf/0.4
Diff against target: 20 lines (+0/-4)
1 file modified
src/bamf-application.c (+0/-4)
To merge this branch: bzr merge lp:~mterry/bamf/no-show-indicators
Reviewer Review Type Date Requested Status
Jason Smith (community) 2010-12-09 Disapprove on 2010-12-10
Review via email: mp+43293@code.launchpad.net

Description of the change

This fixes bug 685634, which is about applications that run as only indicators (not windows) still showing up in the launcher.

To post a comment you must log in.
Jason Smith (jassmith) wrote :

This would break Tomboy/Rhythmbox/Banshee/Gwibber interactions

review: Disapprove

Unmerged revisions

369. By Michael Terry on 2010-12-09

don't show indicators in unity launcher

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/bamf-application.c'
2--- src/bamf-application.c 2010-09-22 14:45:03 +0000
3+++ src/bamf-application.c 2010-12-09 21:10:22 +0000
4@@ -22,7 +22,6 @@
5 #include "bamf-application-glue.h"
6 #include "bamf-window.h"
7 #include "bamf-matcher.h"
8-#include "bamf-indicator.h"
9 #include "bamf-legacy-window.h"
10 #include "bamf-legacy-screen.h"
11 #include <string.h>
12@@ -321,9 +320,6 @@
13
14 running = TRUE;
15
16- if (BAMF_IS_INDICATOR (view))
17- visible = TRUE;
18-
19 if (!BAMF_IS_WINDOW (view))
20 continue;
21

Subscribers

People subscribed via source and target branches