Merge lp:~mterry/appmenu-gtk/lp718926 into lp:~chrisccoulson/appmenu-gtk/lp718926

Proposed by Michael Terry
Status: Merged
Merged at revision: 120
Proposed branch: lp:~mterry/appmenu-gtk/lp718926
Merge into: lp:~chrisccoulson/appmenu-gtk/lp718926
Diff against target: 41 lines (+9/-8)
1 file modified
src/bridge.c (+9/-8)
To merge this branch: bzr merge lp:~mterry/appmenu-gtk/lp718926
Reviewer Review Type Date Requested Status
Chris Coulson Pending
Review via email: mp+51951@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/bridge.c'
2--- src/bridge.c 2011-02-27 16:41:13 +0000
3+++ src/bridge.c 2011-03-02 20:22:54 +0000
4@@ -214,10 +214,6 @@
5 G_CALLBACK(toplevel_unmapped),
6 user_data);
7
8- g_signal_connect(widget, "map",
9- G_CALLBACK (toplevel_mapped),
10- context->bridge);
11-
12 if (context)
13 {
14 free_context_contents (context);
15@@ -548,6 +544,15 @@
16 XID xid;
17 AppWindowContext *context = NULL;
18
19+ /* Disconnect any "map" signal and reconnect, which guarantees that there is
20+ at least one and at most one listener */
21+ g_signal_handlers_disconnect_by_func(toplevel,
22+ G_CALLBACK(toplevel_mapped),
23+ bridge);
24+ g_signal_connect (toplevel, "map",
25+ G_CALLBACK (toplevel_mapped),
26+ bridge);
27+
28 if (!GTK_IS_WINDOW (toplevel))
29 {
30 g_signal_connect (G_OBJECT (toplevel),
31@@ -648,10 +653,6 @@
32 {
33 AppMenuBridge *bridge = APP_MENU_BRIDGE (user_data);
34
35- g_signal_handlers_disconnect_by_func(widget,
36- G_CALLBACK(toplevel_mapped),
37- user_data);
38-
39 if (GTK_IS_WINDOW (widget))
40 {
41 rebuild (bridge, widget);

Subscribers

People subscribed via source and target branches

to all changes: