Application menu module for GTK+

Merge lp:~mterry/appmenu-gtk/blacklist-emacs into lp:appmenu-gtk/0.4

Proposed by Michael Terry on 2011-04-15
Status: Merged
Merged at revision: 133
Proposed branch: lp:~mterry/appmenu-gtk/blacklist-emacs
Merge into: lp:appmenu-gtk/0.4
Diff against target: 21 lines (+3/-1) 1 file modified
To merge this branch: bzr merge lp:~mterry/appmenu-gtk/blacklist-emacs
Reviewer Review Type Date Requested Status
Canonical Desktop Experience Team 2011-04-15 Pending
Review via email: mp+57934@code.launchpad.net

Description of the Change

Guh! I give up on emacs. The last straw was that it fleshed out its menus when it got an X button press event. Our code currently handles applications that flesh out menus upon GTK "activate" signals, but not X button presses.

I looked into an emacs patch that watched "activate", but hit problems. I'll look into that further, but for now, I think it's good to have a fallback in place.

I will push another couple branches for dbusmenu that came out of my emacs odyssey.

To post a comment you must log in.

Preview Diff

1=== modified file 'src/bridge.c'
2--- src/bridge.c 2011-04-12 14:37:43 +0000
3+++ src/bridge.c 2011-04-15 18:48:34 +0000
4@@ -890,7 +890,8 @@
5 return local;
6 }
7
8-/* crude blacklist to avoid patching innoncent apps */
9+/* Crude blacklist to avoid patching innocent apps */
10+/* Use xprop | grep CLASS to find the name to use */
11 static gboolean
12 app_menu_brige_shouldnt_load (void)
13 {
14@@ -903,6 +904,7 @@
15 || (g_strcmp0 (prg, "firefox-bin") == 0)
16 || (g_strcmp0 (prg, "thunderbird-bin") == 0)
17 || (g_strcmp0 (prg, "Eclipse") == 0)
18+ || (g_strcmp0 (prg, "emacs") == 0)
19 || (g_strcmp0 (prg, "gnome-panel") == 0))
20 {
21 return TRUE;

Subscribers

People subscribed via source and target branches